1878010 - unbreak webcam detection on BSD

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Landry Breuil (:gaston)]

Apparently since a recent webrtc upgrade firefox doesn't prompt me anymore for webcam perms, and only the microphone works.

Taking a patch from FreeBSD's portstree (cf https://github.com/freebsd/freebsd-ports/commit/53a70f124869afd195d8eb34e20142e55eaa72cb) allows me to have the correct webcam perms prompt on OpenBSD w/ 123.0b4 & 122.0.

How should this one be upstreamed ? local mozilla patch/commit ?

Comment 1

[Andreas Pehrson [:pehrsons]]

We should just land it in gecko.
Michael, when landing patches on top of gecko's libwebrtc, do we need to do something in regard to moz-patch-stack?

Comment 2

[Michael Froman [:mjf]]

Nothing special needs to be done - the patch-stack will be updated during the libwebrtc fast-forward process either during setup or when rebasing at the end. This is done to avoid rebase conflicts in the patch-stack itself for the person running the update.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1878010 - Fix webrtc::VideoCaptureFactory for BSD. r?#webrtc-reviewers!, r?gaston, r?grulja

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f890637efe5a
Fix webrtc::VideoCaptureFactory for BSD. r=grulja,gaston,webrtc-reviewers,mjf

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f890637efe5a

Comment 6

[Landry Breuil (:gaston)]

thanks :pehrsons!