1878123 - Failing WPT css/css-grid/alignment/grid-[column|row]-axis-self-baseline-synthesized-[001-005].html

Status: NEW

(Core :: Layout: Grid, defect)

Description

[Thomas Wisniewski [:twisniewski]]

See:

• https://wpt.fyi/results/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-001.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-002.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-003.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-004.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-005.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-004.html
• https://wpt.fyi/results/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-005.html

Comment 1

[Daniel Holbert [:dholbert]]

So to get the right results here, we need to synthesize a baseline from the orthgonal flow grid items, and doing that is tracked in bug 1913789 (which is duped forward to bug bug 1947817). Hence, this depends on that work.

Even when we do that, though, I think (based on observations with tlouw) we end up getting baseline offsets of 0 in some cases, rather than a baseline offset from the actual border-box size of the grid item. I think that part is likely a version of bug 1310551. If we manually set an explicit height on the grid item in these cases, we end up getting the right result -- it's just when they're auto-sized that we get the wrong result.

So: it'll be worth circling back here after we've fixed bug 1947817 and bug 1310551 to see what (if anything) is still broken at that point.

Comment 2

[Daniel Holbert [:dholbert]]

Tiaan observed that some of the failing layouts here end up looking visually correct after you resize the window, too (though they're still wrong for the up-front wpt.fyi measurement).

That's a common characteristic of stuff associated with bug 1310551 -- we're get a zero size up-front which gets the wrong baseline, and then after the first reflow, additional incremental reflows will pick up the correct size from the size of the frame (which has now been laid out).

Comment 3

[Jonathan Kew [:jfkthame]]

Most of these tests are now passing, according to wpt.fyi, but we still have a few failures. Interestingly, bug 1953570 seems to have encouraged a couple more passes, but not reliably.... see bug 1953570 comment 13.