1878173 - Remove previous default browser ping caching from Glean telemetry.

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, defect, P2)

Description

[Nick Rishel [:nrishel]]

The default agent caches the previous browser in two registry locations - CurrentDefault and PingCurrentDefault. Glean should not use PingCurrentDefault to populate telemetry as we believe it causes issues when stale for unknown reasons, resulting in seemingly impossible combinations with notification telemetry which is not cached for glean.

Relevant code.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1878173 - Avoid use of registry cached previous default browser ping to avoid telemetry confusion. r=bytesized

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b42121a4f48
Avoid use of registry cached previous default browser ping to avoid telemetry confusion. r=bytesized

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7b42121a4f48

Comment 4

[Nick Rishel [:nrishel]]

Attachment: Bug 1878173 - Avoid use of registry cached previous default browser ping to avoid telemetry confusion. r=bytesized

Original Revision: https://phabricator.services.mozilla.com/D200758

Comment 5

[Phabricator Automation]

Uplift Approval Request

• Is Android affected?: no
• User impact if declined: None, only telemetry
• Steps to reproduce for manual QE testing: n/a
• Code covered by automated testing: no
• String changes made/needed: No
• Fix verified in Nightly: yes
• Explanation of risk level: Only changes the source string for telemetry.
• Risk associated with taking this patch: Low
• Needs manual QE test: no

Comment 6

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• Needs manual QE test: no
• Explanation of risk level: Only changes the source string for telemetry.
• String changes made/needed: None
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• User impact if declined: None, only telemetry
• Is Android affected?: no
• Steps to reproduce for manual QE testing: n/a

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f51ca575b576