1878207 - [wpt-sync] Sync PR 44370 - Always call superclass in HTMLLabelElement::DefaultEventHandler

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44370 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44370
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Always call superclass in HTMLLabelElement::DefaultEventHandler

HTMLLabelElement::DefaultEventHandler does not currently call up to
HTMLElement::DefaultEventHandler in many cases. This patch makes sure
that HTMLLabelElement always calls up to HTMLElement, which makes
\<label>s in \<button>s work.

WebKit's HTMLLabelElement already does this in all branches of
HTMLLabelElement::defaultEventHandler since 2017:
https://github.com/WebKit/WebKit/commit/fec9c1dd147617ff668b9ba8d7d1d4c31fac62de
https://github.com/WebKit/WebKit/commit/b9bad3158f64ba11bca261380c244fbf4cfec31b

Fixed: 1523168
Change-Id: Ib9d0a63befbb930b9595bcc89fb5955050c97b2f

Reviewed-on: https://chromium-review.googlesource.com/5260750
WPT-Export-Revision: dc9279d8c9aa40fd1c5637c0ded11a9bfbc57cd6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f13e236032b6344d6e471a39e6da1d7894f1c0f6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05debd390111
[wpt PR 44370] - Always call superclass in HTMLLabelElement::DefaultEventHandler, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/05debd390111