1878241 - Expand test coverage of "tap followed by pinch" scenario in APZ gtests

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

We have an APZ gtest called TapFollowedByPinch to test the scenario where a tap is followed by a pinch gesture, but the only thing it's testing is that the tap notification goes through (and that the APZC is not left in a dangling PanZoomState).

In this bug I'm going to expand this test to also check that the pinch successfully results in zooming.

(This came up during the review of bug 1798141; if the timing is right, the current version of the bug 1798141 patch can regress this scenario, and I want to add test coverage for this.)

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1878241 - Allow customizing the time between touch events in PinchWithTouchInput(). r=ajakobi

Depends on D200422

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1878241 - Use PinchWithTouchInput() in APZCGestureDetectorTester.TapFollowedByPinch. r=ajakobi

Depends on D200423

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1878241 - In PinchWithTouchInput(), call AdvanceBy() after setting the allowed touch behaviors. r=ajakobi

The touch-start only actually gets processed once the allowed touch
behaviors are specified, so before this patch the touch-start and
touch-move would get processed with no delay between them.

Depends on D200424

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1878241 - Expand APZCGestureDetectorTester.TapFollowedByPinch to also check that the pinch resulted in zooming. r=ajakobi

Depends on D200425

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e15a9dc2436
Allow customizing the time between touch events in PinchWithTouchInput(). r=ajakobi
https://hg.mozilla.org/integration/autoland/rev/d90e438b2bc8
Use PinchWithTouchInput() in APZCGestureDetectorTester.TapFollowedByPinch. r=ajakobi
https://hg.mozilla.org/integration/autoland/rev/79cdece5ed37
In PinchWithTouchInput(), call AdvanceBy() after setting the allowed touch behaviors. r=ajakobi
https://hg.mozilla.org/integration/autoland/rev/7a5ad9c8b72b
Expand APZCGestureDetectorTester.TapFollowedByPinch to also check that the pinch resulted in zooming. r=ajakobi

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1e15a9dc2436
https://hg.mozilla.org/mozilla-central/rev/d90e438b2bc8
https://hg.mozilla.org/mozilla-central/rev/79cdece5ed37
https://hg.mozilla.org/mozilla-central/rev/7a5ad9c8b72b