Synced tabs menu should hide remote "inactive" tabs by default
Categories
(Firefox :: Sync, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
References
Details
Attachments
(2 files)
image.png
iOS recently landed the ability to sync the "inactive" state of its tabs. This bug is for Desktop to not show these tabs by default, but instead add a new menu item, very much like the existing "Show more tabs" item, which shows these inactive items. See attachment.
To test this:
- You need a Firefox iOS 124+ - at time of writing, this means Nightly. Inactive tabs take quite some time to become inactive (2 weeks?), but you can force this by enabling the "secret menu" (open the settings menu, scroll down, then tab on the "Firefox XXX" version entry 5 times - new debug items should appear on the menu) then select "Set Inactive Tab Timeout")
- Wait a few seconds, and ensure that the "tab tray" in Firefox is showing some inactive tabs.
- Settings -> "Sync Now"
Then desktop will show something similar to the above.
Note that Android does not sync this yet, but I hope to get that working soon. If there are no inactive tabs then nothing changes.
This will change only the Synced Tabs menu. We expect Firefox View will probably want to do something similar.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Comment 2•2 years ago
|
||
Thanks for the heads up. Are you planning to roll this out to synced tabs in the sidebar too or keep it within the app menu for now?
|
|
Assignee | |
Comment 3•2 years ago
•
|
||
I don't really have concrete plans :) I guess the sidebar makes sense (I think every surface showing synced tabs makes sense), but I live in hope that "companion" or something similar will kill that sidebar.
If I was 100% honest I'd admit I forgot about it - the main intent was to help demonstrate the feature to UX in the hope of encouraging its implementation in fxview - but I'll see about a patch for that soon.
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
|
||
Comment 6•2 years ago
|
||
:mhammond is this something you would like to mention in the 124 relnotes?
|
|
||
Comment 7•2 years ago
|
||
(In reply to Mark Hammond [:markh] [:mhammond] from comment #3)
I don't really have concrete plans :) I guess the sidebar makes sense (I think every surface showing synced tabs makes sense), but I live in hope that "companion" or something similar will kill that sidebar.
I think I missed this response. The idea is to revamp the existing synced tabs/history sidebar, not kill it (and merge the review checker into it and kill that one-off sidebar created only for it). Is there something in particular you think is problematic about the existing synced tabs sidebar? I'm aware there are quite a few bugs on file, but I haven't had time to read through all of those...
|
|
Assignee | |
Comment 8•2 years ago
|
||
:mhammond is this something you would like to mention in the 124 relnotes?
Sadly only tabs synced from iOS will be shown as inactive, so I don't think saying anything now makes sense as the vast majority of desktop+mobile users will not see any difference.
(In reply to Sarah Clements [:sclements] from comment #7)
Is there something in particular you think is problematic about the existing synced tabs sidebar? I'm aware there are quite a few bugs on file, but I haven't had time to read through all of those...
That sidebar is largely an unmaintainable mess - someone decided to kinda re-invent react from first principles, then promptly leave the company. Working on it is like having a root canal :) That said though, it does generally work from from the user's POV, but just lacks some polish, mainly due to the difficulty in making changes. If I had to do serious work on it, I'd seriously evaluate whether to re architect it first.
Description
•