18784 - [blocker]Selects created via the DOM do not work

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[rods (gone)]

See bug 16821 for the testcase

Comment 1

[rods (gone)]

assigned to M11 as a blocker.

Comment 2

[rods (gone)]

Attachment: Shows appending a new select

Comment 3

[rods (gone)]

Here is what needs to be done for M11:

This code needs to be added to the CreateElement method in the
nsHTMLDocument.cpp:

  nsresult result;
  nsCOMPtr<nsISelectElement> select = do_QueryInterface(content, &result);
  if (NS_SUCCEEDED(result)) {
    result = select->DoneAddingContent();
  }

And :
nsHTMLSelectElement::DoneAddingContent()
needs to always returns NS_OK

Comment 4

[rods (gone)]

Here is the diff that fixes the XUL, I'll check this in tomorrow:
Index: nsXULDocument.cpp
===================================================================
RCS file: /cvsroot/mozilla/rdf/content/src/nsXULDocument.cpp,v
retrieving revision 1.188
diff -r1.188 nsXULDocument.cpp
117a118
> #include "nsISelectElement.h"
4739a4741,4745
>             nsresult srv;
>             nsCOMPtr<nsISelectElement> select = do_QueryInterface(element,
&srv);
>             if (NS_SUCCEEDED(srv)) {
>               srv = select->DoneAddingContent();
>             }

Comment 5

[rods (gone)]

Here is the diff that fixes the XUL's selct:

Index: nsXULDocument.cpp
===================================================================
RCS file: /cvsroot/mozilla/rdf/content/src/nsXULDocument.cpp,v
retrieving revision 1.188
diff -r1.188 nsXULDocument.cpp
117a118
> #include "nsISelectElement.h"
4739a4741,4745
>             nsresult srv;
>             nsCOMPtr<nsISelectElement> select = do_QueryInterface(element,
&srv);
>             if (NS_SUCCEEDED(srv)) {
>               srv = select->DoneAddingContent();
>             }

Comment 6

[rods (gone)]

Just checked in the fixes.

Comment 7

[Jean-Francois Ducarroz]

*** Bug 18885 has been marked as a duplicate of this bug. ***

Comment 8

[leger]

gerardo, can you have someone verify please?  Thanks!

Comment 9

[gerardok]

Verified on 1999-12-21-09-M13 build.