1878674 - Duplicate Metric warning after moving metrics

Status: RESOLVED FIXED

(Data Platform and Tools Graveyard :: Glean Platform, defect, P2)

Description

[Perry McManis [:perry.mcmanis]]

We got some duplicate metric errors on account of GVST migration: https://bugzilla.mozilla.org/show_bug.cgi?id=1875170

Glean has detected duplicated metric identifiers coming from the product 'firefox-android-release'.

• 'gfx.composite_time' defined more than once in engine-gecko, gecko
• 'gfx.scroll_present_latency' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.description' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.device_id' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.driver_date' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.driver_files' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.driver_vendor' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.driver_version' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.ram' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.subsystem_id' defined more than once in engine-gecko, gecko
• 'gfx.adapter.primary.vendor_id' defined more than once in engine-gecko, gecko
• 'gfx.checkerboard.duration' defined more than once in engine-gecko, gecko
• 'gfx.checkerboard.peak_pixel_count' defined more than once in engine-gecko, gecko
• 'gfx.checkerboard.potential_duration' defined more than once in engine-gecko, gecko
• 'gfx.checkerboard.severity' defined more than once in engine-gecko, gecko
• 'gfx.content.full_paint_time' defined more than once in engine-gecko, gecko
• 'gfx.content.paint_time' defined more than once in engine-gecko, gecko
• 'gfx.content.frame_time.from_paint' defined more than once in engine-gecko, gecko
• 'gfx.content.frame_time.from_vsync' defined more than once in engine-gecko, gecko
• 'gfx.content.frame_time.reason' defined more than once in engine-gecko, gecko
• 'gfx.content.frame_time.with_svg' defined more than once in engine-gecko, gecko
• 'gfx.content.frame_time.without_resource_upload' defined more than once in engine-gecko, gecko
• 'gfx.content.frame_time.without_upload' defined more than once in engine-gecko, gecko
• 'gfx.display.count' defined more than once in engine-gecko, gecko
• 'gfx.display.primary_height' defined more than once in engine-gecko, gecko
• 'gfx.display.primary_width' defined more than once in engine-gecko, gecko
• 'gfx.feature.webrender' defined more than once in engine-gecko, gecko
• 'gfx.status.compositor' defined more than once in engine-gecko, gecko
• 'gfx.status.headless' defined more than once in engine-gecko, gecko
• 'gfx.status.last_compositor_gecko_version' defined more than once in engine-gecko, gecko

Comment 1

[Chris H-C :chutten]

This is weird because the rev that "added" these to gecko also removed these from engine-gecko. Both gecko and engine-gecko use mozilla/gecko-dev as their repo, so probe-scraper has all the information necessary to notice that they aren't actually duplicate.

And we've performed transformations like this before by moving metrics from firefox-desktop to gecko in Bug 1805708 (though that was an entire file, so maybe that makes a difference?), so this should've been just fine.

Comment 2

[Chris H-C :chutten]

Oh, and to be clear, all the data is still flowing into all the correct channels. Concretely, for gfx.content.paint_time AKA CONTENT_PAINT_TIME as an example: both Desktop and Android both have been and continue to send this data. The existing data is just fine, and will continue to be while we debug and fix whatever's got probe-scraper's goat.

This error means that the additional Glean instrumentation named in the above list whose data is coming from Gecko-but-not-through-geckoview (e.g. from Firefox Desktop) are currently going into the additional_properties column instead of into columns with those names. Which we're okay with for the little while we're sorting this out, since this data's never been there before, so no one's yet using it.

Comment 3

[Jan-Erik Rediger [:janerik]]

badboy merged PR [mozilla/probe-scraper]: Bug 1878674 - Exempt metrics moving out of geckoview-streaming from duplication checks (#683) in aab3ff8.