1878725 - Enable xyber768 use for TLS 1.3 connections on desktop nightly

Status: RESOLVED FIXED

(Core :: Security: PSM, task, P3)

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1878725 - enable xyber768d00 handshake in desktop nightly. r=keeler

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9310b0f4c23c
enable xyber768d00 handshake in desktop nightly. r=keeler

Comment 3

[Iulian Moraru]

Backed out for causing xpcshell failures on test_httpssvc_retry_with_ech.js.

• Push with failures

• Failure log

• Backout link

[task 2024-02-12T18:47:54.743Z] 18:47:54     INFO -  TEST-START | netwerk/test/unit/test_httpssvc_retry_with_ech.js
[task 2024-02-12T18:47:56.310Z] 18:47:56  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_httpssvc_retry_with_ech.js | xpcshell return code: 0
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  TEST-INFO took 1562ms
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  >>>>>>>
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  running event loop
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  netwerk/test/unit/test_httpssvc_retry_with_ech.js | Starting setup setup
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | start!
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 41] "39512" != null
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 41] "39512" != ""
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 50] Binary util EncryptedClientHelloServer should exist - true == true
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 50] certificate folder (../../../security/manager/ssl/tests/unit/test_encrypted_client_hello) should exist - true == true
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | sending 'GET / HTTP/1.0
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | '
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  (xpcshell/head.js) | test pending (2)
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  (xpcshell/head.js) | test finished (2)
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | HTTP/1.0 200 OK
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | content-type: text/plain
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | connection: close
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | server: httpd.js
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | date: Mon, 12 Feb 2024 18:47:54 GMT
[task 2024-02-12T18:47:56.310Z] 18:47:56     INFO -  PID 3509 | content-length: 3
[task 2024-02-12T18:47:56.312Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 56] "33476" != null
[task 2024-02-12T18:47:56.312Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 57] "33476" != ""
[task 2024-02-12T18:47:56.312Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 60] "AE3+DQBJBwAgACAkFPzLm0ee1tgP3tYrUMCwdE3JlrMLt1o5kR7o3fMCIgAQAAEAAQABAAMAAgABAAIAA0AOcHVibGljLmV4YW1wbGUAAA==" != null
[task 2024-02-12T18:47:56.313Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 61] "AE3+DQBJBwAgACAkFPzLm0ee1tgP3tYrUMCwdE3JlrMLt1o5kR7o3fMCIgAQAAEAAQABAAMAAgABAAIAA0AOcHVibGljLmV4YW1wbGUAAA==" != ""
[task 2024-02-12T18:47:56.313Z] 18:47:56     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2024-02-12T18:47:56.314Z] 18:47:56     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2024-02-12T18:47:56.314Z] 18:47:56     INFO -  netwerk/test/unit/test_httpssvc_retry_with_ech.js | Starting testConnectWithECH
[task 2024-02-12T18:47:56.314Z] 18:47:56     INFO -  (xpcshell/head.js) | test testConnectWithECH pending (2)
[task 2024-02-12T18:47:56.314Z] 18:47:56     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2024-02-12T18:47:56.315Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 224] asyncResolve ok - true == true
[task 2024-02-12T18:47:56.316Z] 18:47:56     INFO -  PID 3509 | *** Connection Activity 0x3 0x5008 .SA.......[tlsflags0x00000000]foo.example.com:40171[TRR:1]
[task 2024-02-12T18:47:56.316Z] 18:47:56     INFO -  PID 3509 | *** Connection Activity 0x3 0x500b .SA.......[tlsflags0x00000000]foo.example.com:40171[TRR:1]
[task 2024-02-12T18:47:56.317Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 1] Checking that this is the correct callback - true == true
<...>
[task 2024-02-12T18:47:56.339Z] 18:47:56     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testEchRetry - [testEchRetry : 309] Histogram flavor valid - true == true
[task 2024-02-12T18:47:56.340Z] 18:47:56     INFO -  PID 3509 | found pre-defined host 'ech-public.example.com'
[task 2024-02-12T18:47:56.340Z] 18:47:56     INFO -  PID 3509 | found pre-defined host 'ech-public.example.com'
[task 2024-02-12T18:47:56.340Z] 18:47:56     INFO -  PID 3509 | PR_Recv failed: SSL_ERROR_ECH_REQUIRED_ALERT
[task 2024-02-12T18:47:56.340Z] 18:47:56     INFO -  Failed to load URL: 804b0014
[task 2024-02-12T18:47:56.340Z] 18:47:56     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:onStopRequest:213
[task 2024-02-12T18:47:56.340Z] 18:47:56     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:245
[task 2024-02-12T18:47:56.341Z] 18:47:56     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:596
[task 2024-02-12T18:47:56.341Z] 18:47:56     INFO -  -e:null:1
[task 2024-02-12T18:47:56.347Z] 18:47:56     INFO -  exiting test
[task 2024-02-12T18:47:56.347Z] 18:47:56     INFO -  Error in onStopRequest: [Exception... "Abort"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: /builds/worker/workspace/build/tests/xpcshell/head.js :: _abort_failed_test :: line 869"  data: no]
[task 2024-02-12T18:47:56.348Z] 18:47:56     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:onStopRequest:232
[task 2024-02-12T18:47:56.348Z] 18:47:56     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:245
[task 2024-02-12T18:47:56.348Z] 18:47:56     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:596
[task 2024-02-12T18:47:56.348Z] 18:47:56     INFO -  -e:null:1
[task 2024-02-12T18:47:56.348Z] 18:47:56     INFO -  exiting test
[task 2024-02-12T18:47:56.349Z] 18:47:56     INFO -  PID 3509 | JavaScript error: /builds/worker/workspace/build/tests/xpcshell/head.js, line 869: NS_ERROR_ABORT:
[task 2024-02-12T18:47:56.350Z] 18:47:56     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "NS_ERROR_ABORT: " {file: "/builds/worker/workspace/build/tests/xpcshell/head.js" line: 869}]
[task 2024-02-12T18:47:56.350Z] 18:47:56     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:869:20
[task 2024-02-12T18:47:56.351Z] 18:47:56     INFO -  do_throw@/builds/worker/workspace/build/tests/xpcshell/head.js:862:3
[task 2024-02-12T18:47:56.351Z] 18:47:56     INFO -  onStopRequest@/builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:232:15
[task 2024-02-12T18:47:56.352Z] 18:47:56     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
[task 2024-02-12T18:47:56.352Z] 18:47:56     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:596:5
[task 2024-02-12T18:47:56.352Z] 18:47:56     INFO -  @-e:1:1
[task 2024-02-12T18:47:56.352Z] 18:47:56     INFO -  "
[task 2024-02-12T18:47:56.353Z] 18:47:56     INFO -  "Force a GC"
[task 2024-02-12T18:47:56.353Z] 18:47:56     INFO -  <<<<<<<
[task 2024-02-12T18:47:56.353Z] 18:47:56     INFO -  TEST-START | netwerk/test/unit/test_trr_confirmation.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7724c952412
enable xyber768d00 handshake in desktop nightly. r=keeler

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1879954 for causing failures on test_delegated_credentials.js.

• backout: https://hg.mozilla.org/integration/autoland/rev/7002e2bab893fbcb8cca9f22848643bcc59396cf

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ab582cb1716
enable xyber768d00 handshake in desktop nightly. r=keeler

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6ab582cb1716

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we should call out in the Nightly release notes?

Comment 9

[John Schanck [:jschanck]]

Release Note Request (optional, but appreciated)
[Why is this notable]: We're beginning to transition our users to state-of-the-art encryption which will secure their communications against emerging threats.
[Affects Firefox for Android]: No
[Suggested wording]: Nightly will attempt to establish TLS connections using a hybrid post-quantum key agreement mechanism (X25519+Kyber768). This may result in slow TLS handshakes or failed connections on networks with TLS intercepting middleboxes. The feature can be disabled by setting security.tls.enable_kyber to false.
[Links (documentation, blog post, etc)]:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Added to the Nightly relnotes, thanks.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Removing from the Nightly release notes as this has been included for more than 3 cycles now. Feel free to nominate it for inclusion once it rides the trains.