Closed Bug 1878727 Opened 2 months ago Closed 2 months ago

Final UX for Yelp suggestions

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

Make sure the Yelp suggestion has final UI.

Whiteboard: [sng]
Assignee: nobody → adw
Status: NEW → ASSIGNED

This makes the Yelp suggestion UI closer to the spec. Summary:

  • Always set isRichSuggestion: true so that the bottom "Yelp · Sponsored" text
    is visible when the row is not a top pick.
  • For the top pick treatment, the icon itself should be 38px and centered in a
    52px box with a border.
  • For the non-top-pick treatment, the icon size should be 24px.
  • Currently rich suggestion rows with 24px icons aren't properly aligned with
    the icons and text in other rows. We have some rules that fix this for rows
    with 16px icons and non-rich suggestions. The problem happens for any row
    whose icon is smaller than the 28px icon of most rich suggestion rows, so I
    added a rule to cover 24px icons.
  • Add HIGHLIGHT.TYPED to the title, but I need to verify this with Loren

References:

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d67ec2218b22
Make the Yelp suggestion UI closer to the spec. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: