1878818 - Fix search-telemetry-v2 schema on Remote Settings

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

The schema updates pass various online JSON schema validation code but a recent change to include domain extraction broke the UI in RS.

My hunch is RS supports an older draft of JSON schema as playing around with modifying the JSON on Dev fixed it.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1878818 - Change search-telemetry schema to use the same sub-schema syntax as search-config - r?standard8!

I think the main issue was the use of ids, but also just to keep things a consistent
between the two in case a team member has to learn how to modify both, it might be
better to use the same syntax.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/761dc4a1c63f
Change search-telemetry schema to use the same sub-schema syntax as search-config - r=Standard8

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/761dc4a1c63f

Comment 4

[James Teow [:jteow]]

Comment on attachment 9378446 [details]
Bug 1878818 - Change search-telemetry schema to use the same sub-schema syntax as search-config - r?standard8!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This bug is required in order to allow Bug 1879714 to also be uplifted to ESR.
• User impact if declined: It would mean we wouldn't be able to make changes to search-telemetry-v2 via Remote Settings without causing a test breakage to browser/components/search/test/unit/test_search_telemetry_config_validation.js.
• Fix Landed on Version: 124
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch shouldn't cause any changes to tests or desktop code, as it just uses a different internal JSON schema syntax.

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9378446 [details]
Bug 1878818 - Change search-telemetry schema to use the same sub-schema syntax as search-config - r?standard8!

Approved for 115.9esr

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/285eb41f942d