1878835 - [wpt-sync] Sync PR 44413 - Add 'writingSuggestions' attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44413 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44413
Details from upstream follow.

Stephanie Zhang <[e-mail]> wrote:

Add 'writingSuggestions' attribute

This CL implements the new 'writingSuggestions' attribute. We add a new
runtime flag and setter/getter methods for it.

The attribute has values "true"/"false" to allow developers to enable or
disable browser-provided writing suggestions. If the attribute is not
explicitly set on an element, it inherits its value from ancestor
elements if specified; otherwise, it default to "true".

Changes were verified against wpt tests:
https://github.com/web-platform-tests/wpt/pull/43780

Intent to Prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE

Bug: 1513953
Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c

Reviewed-on: https://chromium-review.googlesource.com/5247315
WPT-Export-Revision: 443c1460ef6383a995463569c852e815e62d7dcb

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d522a34ce2352d2fbd77dbed26da4e694c992d6d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 68 subtests

Status Summary

Firefox

OK : 1
PASS: 6
FAIL: 62

Chrome

OK : 1
PASS: 6
FAIL: 62

Safari

OK : 1
PASS: 6
FAIL: 62

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/editing/editing-0/writing-suggestions/writingsuggestions.html [wpt.fyi]
  • Test that the writingsuggestions attribute is available on HTMLInputElement.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that the writingsuggestions attribute is available on HTMLTextAreaElement.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that the writingsuggestions attribute is available on HTMLDivElement.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that the writingsuggestions attribute is available on HTMLSpanElement.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that the writingsuggestions attribute is available on custom elements.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to true directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to true directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to boolean true directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to boolean true directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to TrUe directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to TrUe directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to false directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to false directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to boolean false directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to boolean false directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to FaLsE directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to FaLsE directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to the empty string directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to the empty string directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions IDL attribute to an invalid value directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to an invalid value directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test the writing suggestions state when the writingsuggestions attribute is missing.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to false after the IDL attribute was set to true.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to FaLsE after the IDL attribute was set to true.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to boolean false after the IDL attribute was set to true.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to true after the IDL attribute was set to false.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to the empty string after the IDL attribute was set to false.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to an invalid value after the IDL attribute was set to false.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to TrUe after the IDL attribute was set to false.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions content attribute to boolean true after the IDL attribute was set to false.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions attribute with a missing value directly on the target element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions attribute to "true" on a parent element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions attribute to an empty string on a parent element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions attribute to "false" on a parent element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test setting the writingsuggestions attribute to an invalid value on a parent element.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding the parent element's writingsuggestions attribute from "true" to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding the parent element's writingsuggestions attribute from the empty string to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding the parent element's writingsuggestions attribute from "false" to "true".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding the parent element's writingsuggestions attribute from "false" to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding the parent element's writingsuggestions attribute from "false" to the empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test turning off writing suggestions for an entire document.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on an input element from "false" to "true".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a textarea element from "false" to "true".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a div element from "false" to "true".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a span element from "false" to "true".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on an input element from "false" to the empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a textarea element from "false" to the empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a div element from "false" to the empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a span element from "false" to the empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on an input element from "false" to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a textarea element from "false" to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a div element from "false" to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a span element from "false" to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on an input element from "true" to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a textarea element from "true" to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a div element from "true" to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a span element from "true" to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on an input element from the empty string to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a textarea element from the empty string to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a div element from the empty string to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test overriding a non-parent ancestor element's writingsuggestions attribute on a span element from the empty string to "false".: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test that for continuous text on the screen, writing suggestions may be allowed in one part but not another.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c25909ad3c08
[wpt PR 44413] - Add 'writingsuggestions' attribute, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8ef6090f5345
[wpt PR 44413] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c25909ad3c08
https://hg.mozilla.org/mozilla-central/rev/8ef6090f5345