1878917 - Add Action and/or Reducer for Checking for `LanguageNotSupported` and Send Error

Status: RESOLVED FIXED

(Firefox for Android :: Translations, enhancement, P2)

Description

[Olivia Hall [:olivia]]

We need to query if the language is not supported in order to show the correct error state on the UI. LanguageNotSupportedError is the error that should be set on translationsError. For example, visiting a site in a language the engine does not yet support should trigger this error.

This might be as simple as checking the packet that occurs on TranslateStateChangeAction in the Reducer.

Comment 1

[Olivia Hall [:olivia]]

Attachment: Translations-Telemetry-Request-Form.txt

Screenshots of collection points provided here.

Comment 2

[Olivia Hall [:olivia]]

Comment on attachment 9389805 [details]
Translations-Telemetry-Request-Form.txt

Attached request to wrong bug, please ignore.

Comment 3

[Olivia Hall [:olivia]]

(Intended request is now on bug 1883968.)

Comment 4

[Olivia Hall [:olivia]]

Comment on attachment 9389805 [details]
Translations-Telemetry-Request-Form.txt

>
># Request for data collection review form
>
>**All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.**
>
>1) What questions will you answer with this data?
>What areas of the new translations feature do users access most?
>
>2) Why does Mozilla need to answer these questions?  Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:
>
>* Establish baselines of user impact for translations on Android.
>
>* Know if a corresponding release experiment is behaving as expected.
>
>3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
>This is a new feature, so we have limited telemetry on the Android side.
>There is some existing telemetry on the [toolkit side](https://dictionary.telemetry.mozilla.org/apps/fenix?page=1&search=translations), that Android has access too, but none of it is Android UI interaction data.
>
>4) Can current instrumentation answer these questions?
>No, the toolkit side instrumentation only has larger scope information like if a translation occurred. (The panel telemetry does not automatically apply to Android since Android has a separate UI.)
>
>5) List all proposed measurements and indicate the category of data collection for each measurement, using the [Firefox data collection categories](https://wiki.mozilla.org/Data_Collection) found on the Mozilla wiki.
>
>**Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.**
>
><table>
>  <tr>
>    <td>Measurement Description</td>
>    <td>Data Collection Category</td>
>    <td>Tracking Bug #</td>
>  </tr>
>  <tr>
>    <td>Translations Access via Toolbar - Did the user enter translations via toolbar? </td>
>    <td>Interaction data</td>
>    <td>[1883968](https://bugzilla.mozilla.org/show_bug.cgi?id=1883968)</td>
>  </tr>
>  <tr>
>    <td>Translations Access via Browser Menu  - Did the user enter translations via browser menu? </td>
>    <td>Interaction data</td>
>    <td>[1883968](https://bugzilla.mozilla.org/show_bug.cgi?id=1883968)</td>
>  </tr>
>  <tr>
>    <td>Translations Page Settings Access - Did the user enter translations page settings? </td>
>    <td>Interaction data</td>
>    <td>[1883968](https://bugzilla.mozilla.org/show_bug.cgi?id=1883968)</td>
>  </tr>
>  </tr>
>  <tr>
>    <td>Translations Global Settings Access - Did the user enter translations global settings? </td>
>    <td>Interaction data</td>
>    <td>[1883968](https://bugzilla.mozilla.org/show_bug.cgi?id=1883968)</td>
>  </tr>
>  <tr>
>    <td>Translations Language Settings Access  - Did the user enter translations global language settings? </td>
>    <td>Interaction data</td>
>    <td>[1883968](https://bugzilla.mozilla.org/show_bug.cgi?id=1883968)</td>
>  </tr>
>
>  <tr>
>    <td>Translations Never Translate Site Settings Access - Did the user enter translations "never translate site" settings? </td>
>    <td>Interaction data</td>
>    <td>[1883968](https://bugzilla.mozilla.org/show_bug.cgi?id=1883968)</td>
>  </tr>
>
>  <tr>
>    <td>Translations Downloads Access - Did the user enter translations download settings and options? </td>
>    <td>Interaction data</td>
>    <td>[1883968](https://bugzilla.mozilla.org/show_bug.cgi?id=1883968)</td>
>  </tr>
></table>
>
>6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
>This collection is documented in the Glean Dictionary at https://dictionary.telemetry.mozilla.org/.
>
>7) How long will this data be collected?  Choose one of the following:
>
>* I would like this data to be collected until release 135 (potentially renewable).
>
>
>8) What populations will you measure?
>
>* Which release channels?
>All channels.
>
>* Which countries?
>All countries.
>
>* Which locales?
>All locales.
>
>* Any other filters?  Please describe in detail below.
>No.
>
>9) If this data collection is default on, what is the opt-out mechanism for users?
>Standard telemetry opt-out.
>
>10) Please provide a general description of how you will analyze this data.
>It will be used in a release experiment and to guide feature development.
>
>11) Where do you intend to share the results of your analysis?
>In Nimbus reflection or a dashboard.
>
>12) Is there a third-party tool (i.e. not Glean or Telemetry) that you are proposing to use for this data collection? If so:
>No, only using Glean.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1878917 - Add Reducer for Checking for `LanguageNotSupported` and… (#5940)

Comment 6

[BMO Github Automation]

Authored by https://github.com/ohall-m
https://github.com/mozilla-mobile/firefox-android/commit/5a967add556342dfb57dd13caaeb4e2ca3c186b3
[main] Bug 1878917 - Add Reducer for Checking for LanguageNotSupported and Send Error