1878949 - Feature callout menus and menuitems are misaligned on macOS

Status: RESOLVED WORKSFORME

(Firefox :: Messaging System, defect)

Description

[Shane Hughes [:aminomancer]]

Attachment: image.png

See attached. This only affects macOS. It also doesn't seem to affect normal context menus.

STR

1. Set the pref browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
2. Go to about:asrouter
3. Cmd+F to find TEST_FEATURE_TOUR
4. Click the big "Show" button for TEST_FEATURE_TOUR
5. The feature callout should appear
6. Click the downward arrow button in the callout

Comment 1

[Shane Hughes [:aminomancer]]

We did a bisection and found that this was not regressed by bug 1668119. It was present already since the feature was added with bug 1868494.

Comment 2

[Sam Johnson]

The attached screenshot looks like pre-bug 1668119, do you have those changes? That bug should have fixed this specifically.

I tried to reproduce but the "Show" button does not seem to do anything on my system.

Comment 3

[Shane Hughes [:aminomancer]]

Attachment: Bug 1878949 - Move feature callout submenus to a popupset. r=jprickett

Comment 4

[Shane Hughes [:aminomancer]]

(In reply to Sam Johnson from comment #2)

I tried to reproduce but the "Show" button does not seem to do anything on my system.

Are you sure you're hitting "Show" on the right button? There are many "Show" buttons for all the different messages. The one you want specifically is labeled TEST_FEATURE_TOUR.

Comment 5

[Sam Johnson]

(In reply to Shane Hughes [:aminomancer] from comment #4)

Are you sure you're hitting "Show" on the right button? There are many "Show" buttons for all the different messages. The one you want specifically is labeled TEST_FEATURE_TOUR.

Yes, "Show" works for me on some of the other messages such as IMPORT_SETTINGS_EMBEDDED, but not on TEST_FEATURE_TOUR.

Comment 6

[Shane Hughes [:aminomancer]]

Attachment: More recent screenshot

Here's a more recent screenshot

Comment 7

[Shane Hughes [:aminomancer]]

(In reply to Sam Johnson from comment #5)

(In reply to Shane Hughes [:aminomancer] from comment #4)

Are you sure you're hitting "Show" on the right button? There are many "Show" buttons for all the different messages. The one you want specifically is labeled TEST_FEATURE_TOUR.

Yes, "Show" works for me on some of the other messages such as IMPORT_SETTINGS_EMBEDDED, but not on TEST_FEATURE_TOUR.

And you set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true? You sure your repo is up to date? Are there any console logs? Is your window maximized?

Comment 8

[Shane Hughes [:aminomancer]]

Attachment: Latest build

I think you're right, this was actually fixed with your bug. Something went wrong with our mozregression so we got a false impression that it continued from Jan 5 to Feb 6. But on a latest build it looks correct.