Closed Bug 1878957 Opened 2 years ago Closed 1 year ago

ExperimentManager "sessions" member variable logic is hard to follow

Categories

(Firefox :: Nimbus Desktop Client, task)

task

Tracking

()

RESOLVED DUPLICATE of bug 1928476

People

(Reporter: charlie, Unassigned)

References

Details

The sessions member variable of ExperimentManager has some rather tricky logic to follow in relation to understanding what are referred to as "unseen" enrollments. Any refactoring that could be done to simplify or document this logic would be welcomed.

As a specific example, experiments that don't match targeting during the RemoteSettingsExperimentLoader's updateRecipes method don't get added to the source list on the sessions variable, which results in enrolled experiments that no longer match targeting unenrolling under the _checkUnseenEnrollments method.

The work in bug 1928476 removes ExperimentManager.sessions

Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1928476
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.