187908 - In <pageInfo.js>, "Warning: reference to undefined property item.href"

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Henrik Gemal]

if you try to save an image that doesnt exist:

Warning: reference to undefined property item.href
Source File: chrome://navigator/content/pageInfo.js
Line: 718

20030105

Comment 1

[Christopher Hoess (gone)]

WFM in the latest Windows nightly; perhaps this has been fixed by the other
pageinfo changes?

Comment 2

[Henrik Gemal]

not fixed:
Warning: reference to undefined property item.href
Source File: chrome://navigator/content/pageInfo.js
Line: 739

if you press Save As on an image that doesnt exist.

20030320

Comment 3

[Steve Chapel]

Attachment: testcase

Steps to Reproduce:

1. Open attached HTML page
2. Go to View | Page Info
3. Click on the Media tab
4. Click on the Save As... button

Comment 4

[Steve Chapel]

Attachment: patch

Comment 5

[Daniel Brooks [:db48x]]

Comment on attachment 118200 [details] [diff] [review]
patch

you need to change both null checks. It also has nothing to do with whether the
image is missing or not, but it's a bug none the less.

Comment 6

[Steve Chapel]

Attachment: patch to fix both null checks

Comment 7

[Daniel Brooks [:db48x]]

Comment on attachment 118212 [details] [diff] [review]
patch to fix both null checks

looks good

Comment 8

[Daniel Brooks [:db48x]]

Comment on attachment 118212 [details] [diff] [review]
patch to fix both null checks

oops, my bad

Comment 9

[Alec Flett]

Comment on attachment 118212 [details] [diff] [review]
patch to fix both null checks

how about 
if ("href" in item && item.href)

(the null is redundant, IMO)

Comment 10

[Steve Chapel]

> if ("href" in item && item.href)

I agree. Looking through the code, this is the convention used most often. What
should I do -- create a new patch? Sorry, I'm a n00b at patches.

Comment 11

[Daniel Brooks [:db48x]]

yea, go ahead and make another patch. makes it easier for to get someone to
check it in :)

Comment 12

[Steve Chapel]

Attachment: final patch with != null removed

Here's the patch with the != null removed. Could someone check this in for me?
I don't have CVS access.

Comment 13

[(not reading, please use [e-mail] instead)]

Comment on attachment 119469 [details] [diff] [review]
final patch with != null removed

carrying over r/sr. here's your a=sspitzer

Comment 14

[(not reading, please use [e-mail] instead)]

what happened here?  did this have r/sr/a for 1.4 beta, but never checked in?

Comment 15

[Daniel Brooks [:db48x]]

yep. I should have thought about it and asked in irc, that usually works.

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 119469 [details] [diff] [review]
final patch with != null removed

a=asa (on behalf of drivers) for checkin to 1.4.

Comment 17

[Daniel Brooks [:db48x]]

timeless just checked this in