The Highlight Delete and Colors menu does not work if the submenu is on top of a different highlight
Categories
(Firefox :: PDF Viewer, defect, P1)
Tracking
()
People
(Reporter: rdoghi, Assigned: calixte)
References
Details
Attachments
(4 files)
3.48 MB,
video/mp4
|
Details | |
44 bytes,
text/x-github-pull-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-esr128+
|
Details | Review |
Found in
- Nightly 124.0a1 (2024-02-07)
Affected versions
- Nightly 124.0a1 (2024-02-07)
Affected platforms
- All
Steps to reproduce
- Open any PDF in Firefox.
- Enable the highlight tool.
- Highlight any text.
- Free Highlight some Text close to the already highlighted text so that the Delete button overlaps the already Highlighted text.
Expected result
- Delete and Color buttons should have priority over the already highlighted text.
Actual result
- Clicking any of the buttons from the submenu will focus the highlight underneath.
Regression range
Not a Regression
Reporter | ||
Updated•8 months ago
|
Comment 1•8 months ago
|
||
:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?
Assignee | ||
Updated•3 months ago
|
Comment 3•3 months ago
|
||
Reporter | ||
Comment 4•2 months ago
|
||
This issue is Verified as fixed in our latest Nightly build 130.0a1 (2024-07-17) by Bug 1907917.
Updated•2 months ago
|
Comment 5•2 months ago
|
||
The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox129
towontfix
.
For more information, please visit BugBot documentation.
Updated•2 months ago
|
Assignee | ||
Comment 6•2 months ago
|
||
Updated•2 months ago
|
Comment 7•2 months ago
|
||
beta Uplift Approval Request
- User impact if declined: Small
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See comment#0
- Risk associated with taking this patch: Small
- Explanation of risk level: It just make the current selected editor in front of the others.
- String changes made/needed: No
- Is Android affected?: no
Assignee | ||
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Comment 8•2 months ago
|
||
@calixte the phabrcator revision failed to land due to conflicts. Could you take a look?
Updated•2 months ago
|
Updated•2 months ago
|
Assignee | ||
Comment 9•2 months ago
|
||
:donal, done, sorry for the lag: I missed your ni.
Updated•2 months ago
|
Updated•2 months ago
|
Comment 10•2 months ago
|
||
uplift |
Reporter | ||
Comment 11•2 months ago
|
||
Verified as fixed in our latest Beta build 129.0b9.
Assignee | ||
Comment 12•24 days ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D217268
Depends on D220923
Updated•24 days ago
|
Comment 13•24 days ago
|
||
esr128 Uplift Approval Request
- User impact if declined: Low
- Code covered by automated testing: yes
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See bugs 1879035, 1879104, 1907000
- Risk associated with taking this patch: low
- Explanation of risk level: Small and self-contained changes
- String changes made/needed: No
- Is Android affected?: no
Updated•24 days ago
|
Updated•24 days ago
|
Comment 14•24 days ago
|
||
uplift |
Updated•24 days ago
|
Reporter | ||
Comment 15•24 days ago
|
||
Verified as fixed in our latest 128.3.0esr.
Description
•