1879195 - [wpt-sync] Sync PR 44451 - [shared storage] Introduce WorkletOptions param

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44451 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44451
Details from upstream follow.

Yao Xiao <[e-mail]> wrote:

[shared storage] Introduce WorkletOptions param

Introduce WorkletOptions param for both addModule() and
createWorklet(). For the resource request, use the provided
credentials and use the SiteForCookies derived from the RFHI. This
aligns with the worklet standard [1], and aligns with the
implementation for other workers (e.g. for dedicated workers [2]).

Note that the new param for addModule() isn't gated by
kSharedStorageAPIM123. This is intentional: we have been deviating
from the worklet standard, so we consider this change as a bugfix.

[1] https://html.spec.whatwg.org/multipage/worklets.html#dom-worklet-addmodule
[2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/worker_host/dedicated_worker_host.cc?q=WorkerScriptFetcher::CreateAndStart

Bug: 1218540
Change-Id: I82bb7f7509e904f1d9e2ff26c9c8eb1b90ad5828
Reviewed-on: https://chromium-review.googlesource.com/5273828
WPT-Export-Revision: 00339bb45e0e038acf2495c95b9d29e0c4971733

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e972a9d60f9a23bdf38cbb978cbabe156bb42d46

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 6
FAIL: 6

Safari

OK : 6
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /shared-storage/same-origin-add-module-credentials-include.tentative.https.sub.html [wpt.fyi]
  • addModule() with same-origin module script and credentials "include": FAIL (Safari: FAIL)
• /shared-storage/same-origin-add-module-credentials-omit.tentative.https.sub.html [wpt.fyi]
  • addModule() with same-origin module script and credentials "omit": FAIL (Safari: FAIL)
• /shared-storage/same-origin-add-module-credentials-same-origin.tentative.https.sub.html [wpt.fyi]
  • addModule() with same-origin module script and credentials "same-origin": FAIL (Safari: FAIL)
• /shared-storage/same-origin-create-worklet-credentials-include.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with same-origin module script and credentials "include": FAIL (Safari: FAIL)
• /shared-storage/same-origin-create-worklet-credentials-omit.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with same-origin module script and credentials "omit": FAIL (Safari: FAIL)
• /shared-storage/same-origin-create-worklet-credentials-same-origin.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with same-origin module script and credentials "same-origin": FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f497312893f
[wpt PR 44451] - [shared storage] Introduce WorkletOptions param, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1fb307126ed6
[wpt PR 44451] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1f497312893f
https://hg.mozilla.org/mozilla-central/rev/1fb307126ed6