1879386 - Checkboxes and radio buttons do not respect SelectedText color in Windows 10 dark HCM

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Tim Giles [:tgiles]]

Attachment: image.png

Haven't checked on Windows 11 as I don't have a machine for that yet, but our checkboxes and radio buttons do not change their color to the SelectedText system color and instead show the default primary teal color in Windows HCM dark themes. For some reason if I select Windows High Contrast White, the checkboxes and radio buttons use the SelectedText color. Not entirely sure what is going on in this case.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1867769

:emilio, since you are the author of the regressor, bug 1867769, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Tim Giles [:tgiles]]

Not going to claim expertise here, but it looks like we're setting the SelectedItem color in the GenericDarkColor function to the primary teal color seen in the screenshot. Not sure how we would change this without potentially breaking the generic dark color for other platforms if I understand the code correctly.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Really regressed by bug 1789214.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1879386 - Make sure we respect the "must use light colors" bit in non-native theme drawing. r=morgan

This seems hard to reliably test... Basically, this forces all windows
HCM to use "light" system colors for non-native drawing, the same way we
do for system color resolution.

Comment 5

[Bob Hood [:bhood]]

Emilio, can we please get Priority/Severity settings applied here?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/995a3050d70c
Make sure we respect the "must use light colors" bit in non-native theme drawing. r=morgan

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/995a3050d70c

Comment 9

[Monica Chiorean]

I was able to reproduce the issue on Win10x64 using Firefox build 122.0.
Verified as fixed on Win10x64 using Firefox build 124.0b2 and 125.0a1. (Checked that they are correctly displayed on Win11 also)