1879416 - Folder icnons do not appear in Bookmarks menu when no browser windows are open

Status: NEW

(Core :: Widget: Cocoa, defect, P5)

Description

[onerob]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:122.0) Gecko/20100101 Firefox/122.0

Steps to reproduce:

Clicked 'Bookmarks' in the menubar whilst having no open browser windows.

Actual results:

The menu opens showing saved bookmarks and bookmark folders but the folders have no folder icon next to them.

Expected results:

Bookmarks menu should have icons for folders when there are no browser windows open just as they do when a browser window is open.

Comment 1

[Ciprian Georgiu, Desktop QA]

Attachment: issue-no-folder.png

Hello onerob! I've looked into the problem a bit on macOS 13 using Firefox Nightly 124.0a1. In my case, when I minimize the Firefox windows and access the "Other Bookmarks" folder from the menu bar, I see an empty folder (as shown in the attached screencast).

Could you please share a screenshot of what you're seeing? This will help ensure that we're discussing the same issue.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[onerob]

Attachment: Bookmark folder - no active browser window.png

Without an active browser window, there is no folder icon to the left of the folder name. Nor is there space content in the sub-menu of an empty folder.

Comment 4

[onerob]

Attachment: Bookmark folder - browser focused.png

Here is the expected behavior. There is an icon next to the folder name.

Comment 5

[onerob]

Here are two screenshots which show the difference in the display of folders in the bookmarks menu when a window is open and focused versus not focused.

Since filing the bug I have noticed that the issue is the focus/active state of browser windows rather than whether they are open, closed or minimised. It seems that if no browser window is currently the frontmost and thereby activated, then folders in the Bookmarks menu no longer display a folder icon, and it seems if they're empty folders they no longer display the word (Empty) in the submenu of that folder. The problem can be shown by having a browser window open and then opening up the Downloads window in front of it. If the Downloads window is in front of all browser windows then folder icons don't appear, but if a browser window is clicked and activated so that it is in front of the Downloads window then folder icons come back.

Comment 6

[Stephen A Pohl [:spohl]]

Could you run mozregression to see when this started happening? You can either choose to use the GUI tool, or simply run these three commands in a Terminal window:

sudo easy_install pip
sudo python3 -m pip install -U mozregression --ignore-installed
mozregression --good 2017-01-01

A number of Firefox versions will open in succession to narrow down when this started occurring. Simply type "good" or "bad" in Terminal based on whether or not a build reproduces the bug. Once finished, please post the output from the last run. It should give a last good and first bad revision as well as a link to look at the changesets in that range. Thank you!

Comment 7

[onerob]

Tried to run sudo easy_install pip but it failed, claiming 'invalid syntax'.

File "/tmp/easy_install-Ey7iNQ/pip-24.0/setup.py", line 9
    f"pip{sys.version_info[0]}=pip._internal.cli.main:main",
                                                          ^
SyntaxError: invalid syntax

Unforntutely the GUI version of mozregression isn't working either.

Comment 8

[Ciprian Georgiu, Desktop QA]

Onerob, I'm not sure which version of the GUI you've tested, but could you please verify if this version works: https://github.com/mozilla/mozregression/releases/download/6.0.2/mozregression-gui.dmg? If not, you can find other versions on the Mozilla mozregression releases page in case this one isn't compatible.

I attempted to run mozregression to identify the regression, but unfortunately, it seems that the bug indicated in this push log may not be the correct one [1]. Interestingly, I ran the regression twice and obtained the same output both times.

[1] https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c96676ffbb661424f4a40ed4d8103b63600ad56b&tochange=f37d7f067cfea5e22599cb76fccf91d049de3ff1

Comment 9

[onerob]

I've tried mozregression 6.0.2, 5.9.1, 5.7.0 and 5.4.0 but none of them work. I might get a little splash screen saying that mozregression is starting but nothing happens beyond that. I'm running MacOS 10.15 which perhaps is too old for mozregression. I could try updating Python?