1879483 - FirefoxAndroidWdSpecBrowser class creates and uses a profile for desktop

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The FirefoxAndroidWdSpecBrowser class inherits from FirefoxWdSpecBrowser which sets-up a desktop profile. But instead it needs to use the ProfileCreator from firefox_android.py to correctly set Android specific preferences, but that doesn't happen at the moment.

That means as well that I'm not able to set specific preferences that only apply on Android. And that's needed for bug 1693857.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that wptrunner doesn't use multiple inheritance I wonder if just overriding the profile property is fine even through it means that we have created an extra profile folder that for sure we should correctly clean-up. Otherwise we could pass the expected ProfileCreator class to the FirefoxWdSpecBrowser init method?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1879483 - [wptrunner] Use the correct ProfileCreator class in FirefoxAndroidWdSpecBrowser.

Depends on D198681

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20876ae07c4b
[wptrunner] Use the correct ProfileCreator class in FirefoxAndroidWdSpecBrowser. r=jgraham

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44519 for changes under testing/web-platform/tests

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/20876ae07c4b

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot