1879533 - Intermittent browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js | single tracking bug

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=446645043&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XQVehjJORhu0f7kKmKTclQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-02-09T11:37:54.998Z] 11:37:54     INFO - TEST-PASS | browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js | Dialog's OK button should not be disabled - 
[task 2024-02-09T11:37:54.999Z] 11:37:54     INFO - Buffered messages finished
[task 2024-02-09T11:37:55.001Z] 11:37:55     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js | There should be 3 opens from browser context - Got 2, expected 3
[task 2024-02-09T11:37:55.001Z] 11:37:55     INFO - Stack trace:
[task 2024-02-09T11:37:55.001Z] 11:37:55     INFO - chrome://mochikit/content/browser-test.js:test_is:1620
[task 2024-02-09T11:37:55.001Z] 11:37:55     INFO - chrome://mochitests/content/browser/browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js:testEntryPointTelemetry:1302
[task 2024-02-09T11:37:55.001Z] 11:37:55     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-02-09T11:37:55.002Z] 11:37:55     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-02-09T11:37:55.002Z] 11:37:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-02-09T11:37:55.002Z] 11:37:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-02-09T11:37:55.003Z] 11:37:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-02-09T11:37:55.403Z] 11:37:55     INFO - TEST-PASS | browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js | Warning panel should not be visible for non-TIMESPAN_EVERYTHING - 

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1874835

:hsohaney, since you are the author of the regressor, bug 1874835, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Intermittent Failures Robot]

10 failures in 4009 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 5
• autoland: 4
• try: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 6
  • opt: 6
• linux1804-64-qr: 3
  • opt: 3
• macosx1100-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1879533&startday=2024-02-05&endday=2024-02-11&tree=all

Comment 3

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1879533 - Fixing telemetry async intermittent by awaiting for data size loading after collecting telemetry. r?pbz

Comment 4

[Intermittent Failures Robot]

25 failures in 3125 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #36 most frequent failure this week.

Repository breakdown:

• autoland: 12
• mozilla-central: 11
• try: 2

Platform and build breakdown:

• macosx1100-64-shippable-qr: 9
  • opt: 9
• linux1804-64-shippable-qr: 6
  • opt: 6
• linux1804-64-qr: 4
  • opt: 4
• macosx1015-64-devedition-qr: 1
  • opt: 1
• macosx1015-64-qr: 2
  • opt: 2
• windows11-64-2009-qr: 1
  • debug: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1
• windows11-64-2009-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1879533&startday=2024-02-12&endday=2024-02-18&tree=all

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1874835

Comment 6

[Intermittent Failures Robot]

50 failures in 3382 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #24 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 32
• mozilla-central: 12
• mozilla-beta: 4
• try: 2

Platform and build breakdown:

• linux1804-64-qr: 5
  • opt: 5
• linux1804-64-shippable-qr: 16
  • opt: 16
• macosx1100-64-shippable-qr: 17
  • opt: 17
• windows11-64-2009-qr: 1
  • debug: 1
• macosx1015-64-shippable-qr: 5
  • opt: 5
• macosx1015-64-qr: 3
  • opt: 3
• macosx1015-64-devedition-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 1
  • opt: 1
• windows11-64-2009-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1879533&startday=2024-02-19&endday=2024-02-25&tree=all

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fbea27fb675
Fixing telemetry async intermittent by awaiting for data size loading after collecting telemetry. r=pbz

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5fbea27fb675

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:hsohaney, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Harshit Sohaney [:hsohaney]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #10)

The patch landed in nightly and beta is affected.
:hsohaney, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Since this test consistently fails in beta, I think we can uplift this to prevent test breakage in beta!

Comment 12

[Dianna Smith [:diannaS]]

:hsohaney can you nominate this for beta uplift when you get a chance? I would need the form filled out since this isnt just fixing a test.

Comment 13

[Intermittent Failures Robot]

8 failures in 4052 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4
• mozilla-central: 2
• try: 1
• mozilla-beta: 1

Platform and build breakdown:

• macosx1100-64-shippable-qr: 7
  • opt: 7
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1879533&startday=2024-02-26&endday=2024-03-03&tree=all

Comment 14

[Harshit Sohaney [:hsohaney]]

Comment on attachment 9380458 [details]
Bug 1879533 - Fixing telemetry async intermittent by awaiting for data size loading after collecting telemetry. r?pbz

Beta/Release Uplift Approval Request

• User impact if declined: No user impact. This feature isn't enabled in beta/release.
  The fix is for an intermittent failure.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature isn't enabled in beta/release
• String changes made/needed:
• Is Android affected?: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9380458 [details]
Bug 1879533 - Fixing telemetry async intermittent by awaiting for data size loading after collecting telemetry. r?pbz

Approved for 124.0b8.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/234ebdc145f2