Closed Bug 1879642 Opened 2 months ago Closed 2 months ago

Update Yelp suggestion desktop integration for changes in Rust prefix matching

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

We'll need to update the Yelp JS to account for changes in the Rust component in bug 1879640 and maybe make some other changes too to make sure the desired prefix matching behavior is implemented correctly.

The main change is to makeResult(). I talked with Loren and we came up with
these rules for prefix matching:

  • The entire search string has to be at least 5 characters long, and
  • At least 2 characters of the subject have to be typed

This patch enforces the 5 char overall threshold using the existing Nimbus
variable. If a subject is less than 5 chars, then we'll show it if there's an
exact match.

Other changes:

  • Add yelp.minKeywordLength and yelp.showLessFrequentlyCap fallback prefs to
    make it easier to write tests and demo this feature
  • Rename the quicksuggest.yelpPriority pref so it's consistent with others
  • Add yelp.featureGate to firefox.js so it shows up in about:config so it's
    easier to try out this feature
  • Alphabetize the prefs in UrlbarPrefs. Some newer ones are out of order.

Depends on D201300

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f72266ed1a1f
Update Yelp suggestion desktop integration for changes in Rust prefix matching. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: