1879682 - [wpt-sync] Sync PR 44518 - Revert "FLEDGE: field trial testing config for 20->40 in component ads limit"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44518 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44518
Details from upstream follow.

[e-mail] <[e-mail]> wrote:

Revert "FLEDGE: field trial testing config for 20->40 in component ads limit"

This reverts commit c825fae53cdfa08b33e560c15bb7020e0646a451.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5753898272817152

Sample build with failed test: https://ci.chromium.org/b/8756530589944850161
Affected test(s):
ninja://content/test:content_browsertests/InterestGroupBrowserTest.ComponentAuctionValidateWorkletParametersOldRunAdAuctionNames
ninja://content/test:content_browsertests/InterestGroupComponentWorkletValidationBrowserTest.ComponentAuctionValidateWorkletParameters/All.top_level_subresource_bundle_direct_from_seller_signals_component_subresource_bundle_direct_from_seller_signals
ninja://content/test:content_browsertests/InterestGroupWorkletValidationBrowserTest.ValidateWorkletParameters/All.subresource_bundle_direct_from_seller_signals

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5753898272817152&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5280539&type=BUG

Original change's description:

FLEDGE: field trial testing config for 20->40 in component ads limit

Fix the bug this revealed, and update test expectations to notice the corresponding feature detection browser signals showing up. Also add a new WPT test for new limit, since I was in the neighborhood anyway.

Bug: 324445653

Change-Id: Ib1f3d23f0ea2657c8e27cab67caddff1208825e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280539
Reviewed-by: Russ Hamilton \<[e-mail]>
Commit-Queue: Maks Orlovich \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1258749}

Bug: 324445653
Change-Id: I60ed84e1607b879446e09b53e824368a3a4cd209
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/5282851
WPT-Export-Revision: a2a43701c568094cde9410531dddc7326fbab4fe

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 4 subtests

Status Summary

Firefox

OK : 5
FAIL : 27

Chrome

OK : 4
PASS : 6
FAIL : 14
TIMEOUT: 2
NOTRUN : 6

Safari

OK : 5
FAIL : 27

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fenced-frame/get-nested-configs.https.html [wpt.fyi]
  • getNestedConfigs() created by FLEDGE should return configurations: FAIL (Chrome: FAIL, Safari: FAIL)
  • getNestedConfigs() from a fenced frame with the config from sharedStroage.selectURL() should be empty: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • getNestedConfigs() from a fenced frame with the urn:uuid from sharedStroage.selectURL() should be empty: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • getNestedConfigs() from a default mode frame should be empty: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • getNestedConfigs() should work in a same-origin nested iframe: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Nested configs created by FLEDGE should be navigable by fenced frame: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Nested configs created by FLEDGE should be navigable by URN iframe: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Navigating an invalid config should be handled gracefully: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /fledge/tentative/component-ads.https.window.html?6-10 [wpt.fyi]
  • Unknown component ad URL in bid.: FAIL (Chrome: PASS, Safari: FAIL)
  • Render URL used as component ad URL in bid.: FAIL (Chrome: PASS, Safari: FAIL)
  • Component ad URL used as render URL.: FAIL (Chrome: PASS, Safari: FAIL)
  • 2 of 2 component ads in bid and then shown.: FAIL (Chrome: FAIL, Safari: FAIL)
  • 2 of 2 component ads in bid and then shown, with metadata.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/component-ads.https.window.html?1-5 [wpt.fyi]
  • Group has no component ads, no adComponents in bid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Group has no component ads, adComponents in bid is empty array.: FAIL (Chrome: PASS, Safari: FAIL)
  • Group has component ads, but not used in bid (no adComponents field).: FAIL (Chrome: FAIL, Safari: FAIL)
  • Group has component ads, but not used in bid (adComponents field empty array).: FAIL (Chrome: FAIL, Safari: FAIL)
  • Unused component ads with metadata.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/component-ads.https.window.html?11-15 [wpt.fyi]
  • 2 of 20 component ads in bid and then shown.: FAIL (Chrome: FAIL, Safari: FAIL)
  • 20 of 20 component ads in bid and then shown.: FAIL (Chrome: FAIL, Safari: FAIL)
  • 6 of 20 component ads in bid, 2 shown.: FAIL (Chrome: FAIL, Safari: FAIL)
  • 4 of 4 component ads shown multiple times.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Same component ad used multiple times in bid.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fledge/tentative/component-ads.https.window.html?16-last [wpt.fyi]
  • Load component ads not in bid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • 21 component ads not allowed in bid.: FAIL (Chrome: PASS, Safari: FAIL)
  • Same component ad not allowed 21 times in bid.: FAIL (Chrome: PASS, Safari: FAIL)
  • Reports not sent from component ad.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f984e646584b
[wpt PR 44518] - Revert "FLEDGE: field trial testing config for 20->40 in component ads limit", a=testonly

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f984e646584b