Closed
Bug 1879811
Opened 2 years ago
Closed 2 years ago
Cleanup some ESLint rule configurations
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox124 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(3 files)
There's various places where we are configuring ESLint rules that are already enabled in ESLint's recommended config, or are in the recommended config that we define for eslint-plugin-mozilla.
There's also a couple of items that are no longer needed, and we can replace the deprecated no-new-object with no-object-constructor.
Overall, this is clean up to help make it clearer about the differences in configuration across the various parts of mozilla-central.
|
Assignee | |
Comment 1•2 years ago
|
||
The require-atomic-updates is not in ESLint's recommended list, so won't get enabled.
The preprocessor definition is no longer required, especially as we don't have a xml
preprocessor now.
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c3288afae57
Cleanup some unneeded definitions in eslint-plugin-mozilla's recommended.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d26df3c4200c
Avoid re-enabling ESLint rules when they are already enabled by ESLint's recommended configuration, or mozilla-central's one. r=Gijs,webcompat-reviewers,extension-reviewers,devtools-reviewers,twisniewski
https://hg.mozilla.org/integration/autoland/rev/d8130f803bf8
Replace deprecated ESLint rule no-new-object with no-object-constructor. r=Gijs,webdriver-reviewers,whimboo
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•