1880067 - Typing in Firefox View's history search causes flickering and loss of characters typed

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Mark Banner (:standard8)]

I just tried searching history on the latest nightly on a Mac M1 Pro.

I started typing mozsearch as I got to about the fourth or fifth character, the screen flickered, updated, and lost characters in the search - my search came out as mozearch.

It all depends on timing, but generally you have to be typing when the auto-refresh kicks in.

I'm not quite sure the flickering is true flickering, because of the the update and the potential changes, it felt like it was flickering, but it might have just been the way it updates the page. The main thing is that loss of characters when typing.

Comment 1

[Sarah Clements [:sclements]]

I also just noticed this recently too.

Comment 2

[Stuart Colville [:muffinresearch]]

In case this is relevant, the most recent macOS update (e.g. for Sonoma it's 14.3.1) mentions "Text may unexpectedly duplicate or overlap while typing". I'm doubtful this bug is caused by that, but thought it work checking that this still reproduces with this update installed.

Comment 3

[Sarah Clements [:sclements]]

[Tracking Requested - why for this release]:

(In reply to scolville from comment #2)

In case this is relevant, the most recent macOS update (e.g. for Sonoma it's 14.3.1) mentions "Text may unexpectedly duplicate or overlap while typing". I'm doubtful this bug is caused by that, but thought it work checking that this still reproduces with this update installed.

Yeah, I'm on Sonoma 14.2.1 and I still see it. Since we want to get this uplifted to 124 beta since search is going to be rolled out in 123 I'm going to have relman track this.

Comment 4

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1880067 - Typing in Firefox View's history search causes flickering and loss of characters typed r?#fxview-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/321b20cb103f
Typing in Firefox View's history search causes flickering and loss of characters typed r=fxview-reviewers,sclements

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/321b20cb103f

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jsudiaman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1880067 - Typing in Firefox View's history search causes flickering and loss of characters typed r?#fxview-reviewers

Original Revision: https://phabricator.services.mozilla.com/D202248

Comment 9

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• Explanation of risk level: Removes an unnecessary two way binding to the search box which was not used in other categories of Firefox View.
• User impact if declined: Typing in Firefox View's history search causes loss of characters typed.
• String changes made/needed: None
• Code covered by automated testing: yes
• Needs manual QE test: yes
• Is Android affected?: no
• Fix verified in Nightly: no
• Steps to reproduce for manual QE testing: 1. Open Firefox View (Firefox View tab is placed at the beginning of the tab bar). 2. Switch to the "History" category. 3. Type something in the search bar.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba264d129db8

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 124.0a1 (2024-02-13) on macOS 13.6.4.
The issue is no longer reproducible on Firefox 124.0b3 (treeherder build) and Firefox 125.0a1. Tests were performed on macOS 13.6.4, Windows 11 and Ubuntu 23.10.