1880071 - Make GetProxyType return an enum instead of a string

Status: NEW

(Core :: Networking: Proxy, task, P3)

Description

[Manuel Bucher [:manuel]]

This would make code much simpler. No string compare needed. The variable is used like an enum anyway.

• Noticed while writing Bug 1879848
• Already mentioned in Bug 805457 comment 2

I think it would be great to include the different DNS over Proxy aspect and not have a separate flag.

enum {
  HTTP,
  HTTPS,
  HTTP2, // <- maybe not, this is only https, but proxy server negociated http2, could be done in a followup 1
  SOCKS4,
  SOCKS4a, // <- maybe just SOCKS4, with (flags & nsIProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST), could be done in a follow up 2
  SOCKS5,
  SOCKS5h, // <- maybe just SOCKS5, with (flags & nsIProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST), could be done in a follow up 2
}

This is how curl differentiate between proxy types: https://curl.se/libcurl/c/CURLOPT_PROXY.html