1880106 - [Experiment] The “Add-ons” notification is briefly displayed and dismissed when shown for the 4th time

Status: VERIFIED FIXED

(Firefox for Android :: Experimentation and Telemetry, defect)

Description

[Valentin Bandac [:vbandac], Ecosystem QA]

[Affected versions]:

• Firefox Release 120.0.1 (Build ID: 2015988378)
• Firefox Release 122.0 (Build ID: 2015998386)
• Firefox Release Candidate 123.0 (Build ID: 2016003218)

[Affected Platforms]:

• Android 11 - OnePlus 6
• Android 12 - Samsung A23
• Android 13 - Samsung A32
• Android 14 - Samsung A53

[Prerequisites]:

• Have a new Firefox profile.
• Use the nimbus-cli command to enroll in the Treatment A branch of the experiment:
  nimbus-cli --app fenix --channel release enroll preview/new-user-add-ons-reminder-copy-test-android --branch treatment --preserve-targeting -- -n org.mozilla.firefox/mozilla.telemetry.glean.debug.GleanDebugActivity --ez logPings true --es sendPing events --es debugViewTag [your_tag]

[Steps to reproduce]:

1. Open Firefox and close the onboarding screens.
2. Restart Firefox 5 times and dismiss the "Set to Default" Notification.
3. Navigate to a website and open a new tab.
4. Repeat step 3 three times and observe the "Add-ons" notification.

[Expected result]:

• The “Add-ons” notification is correctly displayed when triggered for the 4th time.

[Actual result]:

• The “Add-ons” notification is briefly displayed and dismissed when triggered for the 4th time.

[Notes]:

• The “message_shown” telemetry pings are received 4 times, as expected.
• Added screen recording of the issue. You can find it here.

Comment 1

[C Gordon]

Hi Valentin, Could you confirm if you're seeing the issue after the 6th launch OR is it the 4th launch as you mentioned? The add-ons message should be triggered on the 6th app launch, if the set to default message has been dismissed. The add-on message should have a lower priority than the set to default message.

Comment 2

[Valentin Bandac [:vbandac], Ecosystem QA]

Hey Courtney,
I can confirm that we’re seeing the issue after the 6th launch. The add-ons message is triggered on the 6th app launch, when the set to default message has been dismissed. The add-on message is not displayed as long as the set to default message is.
The issue is that the max display count of the "Add-ons" message is 4, but is displayed only 3 times after being triggered, and the 4th time it is briefly displayed and dismissed.

Comment 3

[Punam Dahiya [:pdahiya]]

From feedback in slack thread here , this seems to be a existing issue in embedding app

"Fenix’s unidirectional data loop selects a message (via getNextMessage), calls onMessageDisplayed then checks for message expiry. If the message has expired then it immediately removes the message from display. Removing this line will probably fix the problem."

Comment 4

[Vlad Dreghici [:vdreghici]]

Attachment: Bug 1880106 - Correctly display message when max display count reached

Comment 5

[Vlad Dreghici [:vdreghici]]

This issue can be reproduced on the Microsurvey prompt as well, which leads me to believe it happens with any message. I added a patch which aims to not immediately consume a message after it is shown, if it is expired. Below are videos of before and after, with the microsurvey prompt.

Comment 6

[Vlad Dreghici [:vdreghici]]

Attachment: display-count-beforeScreen_recording_20240703_163611.mp4

Before video of microsurvey prompt being displayed only 4 times, with a max-display-count of 5

Comment 7

[Vlad Dreghici [:vdreghici]]

Attachment: max-display-afterScreen_recording_20240703_164014.mp4

Video with the behavior after attached patch, where the microsurvey prompt is correctly displayed 5 times, according to the max-display-count of 5.

Comment 8

[Vlad Dreghici [:vdreghici]]

Attachment: Bug 1880106 - Correctly show message when max display count reached

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74ecc190ee38
Correctly show message when max display count reached r=android-reviewers,amejiamarmol

Comment 10

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/74ecc190ee38

Comment 11

[Valentin Bandac [:vbandac], Ecosystem QA]

I have verified this issue on latest Nightly 130.0a1 (Build: 2016034514 hg-a0e3db73fd24+, GV: 130.0a1-20240724215903, AS: 130.20240724050232) on Android 11 - OnePlus 6 and Android 14 - Samsung A53.

The “Add-ons” notification is correctly displayed when triggered for the 4th time.

Considering this I will mark the issue as Verified - Fixed.