1880122 - [wpt-sync] Sync PR 44562 - Only check for matching mode in attachShadow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44562 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44562
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Only check for matching mode in attachShadow

Per the new-new consensus, attachShadow will only verify that
the existing declarative shadow root's mode matches the newly
requested mode:

https://github.com/whatwg/html/issues/10107#issuecomment-1937077298

Bug: 41483062
Change-Id: Ie3bac4ec297c0b85c40b45495e9c823dd47cb49e
Reviewed-on: https://chromium-review.googlesource.com/5283935
WPT-Export-Revision: d0de79f1d92e3bb303388d6d8db84d3d232bd863

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44562 applied with additional changes from upstream: 33d11f1db34802fda00e64ddeb0b7ef040cf65be

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44562 applied with additional changes from upstream: 6318d09b67bd4978f9bd2a271d2da54d9db70334

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4faaf946e253bdb688e36afccbf00e68c51000ec

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
PASS: 2
FAIL: 1

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /shadow-dom/declarative/declarative-shadow-dom-repeats.html [wpt.fyi]
  • Repeated declarative shadow roots keep only the first: FAIL (Chrome: PASS, Safari: FAIL)
  • Calling attachShadow() on declarative shadow root must match mode: FAIL (Chrome: PASS, Safari: FAIL)
  • Calling attachShadow() on declarative shadow root must match all parameters: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7824a0c135be
[wpt PR 44562] - Only check for matching mode in attachShadow, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1b4880e162c5
[wpt PR 44562] - Update wpt metadata, a=testonly

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7824a0c135be
https://hg.mozilla.org/mozilla-central/rev/1b4880e162c5