1880223 - When the window is reduced in size, the "No proxy for" text field within the Connections Settings does not display a scrollbar

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: scroll_0.gif

Found in

• 124.0a1 (2024-02-13)

Affected versions

• 124.0a1 (2024-02-13)

Tested platforms

• Affected platforms: Ubuntu 22, Windows 10x64
• Unaffected platforms: macOS 12

Steps to reproduce

1. Open about:preferences#general and scroll down to Network Settings.
2. Click on Settings and add some text until the text field overflows.

Expected result

• A scrollbar is displayed.

Actual result

• No scrollbar is displayed.

Regression range

• Last good revision: 6b7c9fbc0ffaf2a78cc6f22c34dfab000f8aeaaf
  First bad revision: cd42800e011bd3c11cc8c3191a48081d3b4d12a6
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6b7c9fbc0ffaf2a78cc6f22c34dfab000f8aeaaf&tochange=cd42800e011bd3c11cc8c3191a48081d3b4d12a6

Additional notes

• Attached a screen recording.
• The scrollbar is displayed if the text field has a certain height, for example opening the window while Firefox is fullscreen will show the scrollbar.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:jules, since you are the author of the regressor, bug 1877793, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Jules Simplicio [:jules]]

Hey there, it looks like this was an existing issue that is unrelated to the heading changes I made.
The scrollbar seems to behave differently depending on your window size when you open these settings.

I'm happy to push a potential fix for this by removing the min-height set on this specific input, which seems to fix this issue.

FWIW the new h2 heading also does look out of place in this dialog though, so I am happy to also revert it to the old size with my changes. I'm thinking this is what actually caused the dialog size change which is causing this scrollbar issue to be more noticeable now.

Comment 3

[Jules Simplicio [:jules]]

Attachment: Bug 1880223 - Set auto min-height in textareas and fix heading sizing in connection settings r?#desktop-theme-reviewers,#settings-reviewers,sfoster

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1877793

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b385f8cd6210
Set auto min-height in textareas and fix heading sizing in connection settings r=desktop-theme-reviewers,settings-reviewers,emilio

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b385f8cd6210

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jules, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 125.0a1 (2024-02-21) on Windows 10x64, macOS 13, and Lubuntu 22. The scroll bar is displayed after following the steps from comment 0.