Closed Bug 1880240 Opened 1 year ago Closed 1 year ago

capability.policy.localfilelinks crashes tab on internals site

Categories

(Firefox :: Enterprise Policies, defect, P3)

Product:
Firefox
Component:
Enterprise Policies
Version:
Firefox 122
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1834864

People

(Reporter: marcodifeo, Unassigned)

Details

Attachments

(1 file)

Result
186.71 KB, text/plain
Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36 Edg/121.0.0.0

Steps to reproduce:

I opened Firefox, and entered the complete url for an internal https://marktplatz.<xyz-internal>.de website. Then I pressed enter for load the website.

This happens on different computer, on different Firefox Browser (e.g. ESR 115.x)

It doesn't happen on Firefox ESR 91 and less.
We use Firefox with policies. When I remove the <xyz-internal>.de domain from the policy settings list of capability.policy.localfilelinks, the website shows up correctly

Actual results:

Firefox opens the website and immediately crashes. I can read "Der Tab ist gerade abgestürzt" (Gah. Your tab just crashed).

Expected results:

The Website should load correctly

The Bugbug bot thinks this bug should belong to the 'Firefox::Enterprise Policies' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Enterprise Policies

Marco, if possible can you please add the errors from Browser console. Thank you.

Flags: needinfo?(marcodifeo)

(In reply to Monica Chiorean from comment #2)

Marco, if possible can you please add the errors from Browser console. Thank you.

I don't know what I have to send, because the tab crashes immediately. I uploaded a crash report, is this enough?
https://crash-stats.mozilla.org/report/index/e3276d53-1338-4e74-84e1-ccfa00240216#tab-annotations

Flags: needinfo?(marcodifeo)

That does help.

We have a tool that helps us track down regressions. Is there any way you could see if it could be used to find when this broke?

Forgot the link:

https://mozilla.github.io/mozregression/

Unfortunately I can't recreate. Do you know if that website accesses a local file immediately on loading?

Looking at the crash report, we have bug 1834864 on file for this signature.

Attached file Result —
Hi Mike, I executed mozregression, but it ended with an error similar to "not enough data to bisect", so I started it again. Here is the log: ```

The problem started with Firefox Version 105 (105.0b1 is broken as well). Hopefully you have all the information you need for your investigation.
Kind Regards
Marco

I'm trying to reproduce and I'm trying to figure out why it happens when the page is loaded.

Do you have any insight into what this page is doing? Is it possible it's embedding a local PDF or something like that?

(Things I've tried are embedding a local PDF as an object as well as just linking to a local file)

As I can see there is no PDF Download or anything like that. The website is more like a internal website for selling furniture. It is based on bootstrap and isn't that complex.

I'm at a loss as to what could be causing this.

Does that page maybe have an embedded PDF?

Can you try going to about:config

Setting:

pdfjs.disabled

to true and seeing if it stops the crash as well?

Flags: needinfo?(marcodifeo)

Sorry for my delayed posting.
There is no PDF, it's just a simple site, that looks like an onlineshop for furniture in simple bootstrap back in 2015.

I found this at the end, that seems to initiate some kind of input fields.
$(document).ready(function() {
bsCustomFileInput.init();
});

Here is an overview of the linked JS files, maybe there is something special?
/lib/bootstrap/dist/css/bootstrap.min.css
/lib/font-awesome/css/all.min.css
/lib/bootstrap-select/dist/css/bootstrap-select.min.css
/lib/datatables.net-bs4/dataTables.bootstrap4.min.css
/lib/datatables-fixedheader/fixedHeader.dataTables.min.css
/lib/datatables.net-rowgroup/dataTables.rowGroup.css
/lib/lightbox2/css/lightbox.min.css
/lib/datatables-searchhighlight/dataTables.searchHighlight.css
/lib/jquery/jquery.min.js
/lib/bootstrap/dist/js/bootstrap.bundle.min.js
/lib/bootstrap-select/dist/js/bootstrap-select.min.js
/lib/font-awesome/js/all.min.js
/lib/datatables.net/jquery.dataTables.min.js
/lib/datatables.net-bs4/dataTables.bootstrap4.min.js
/lib/datatables-fixedheader/dataTables.fixedHeader.min.js
/lib/moment.js/moment-with-locales.min.js
/lib/datatables.net-moment/datetime-moment.js
/lib/datatables.net-rowGroup/dataTables.rowGroup.min.js
/lib/underscore.js/underscore-min.js
/lib/barcoder/barcoder.js
/lib/jquery-highlight/jquery.highlight.js
/lib/datatables-searchhighlight/dataTables.searchHighlight.min.js
/lib/bs-custom-file-input/bs-custom-file-input.min.js
/lib/lightbox2/js/lightbox.min.js
/lib/jsbarcode/JsBarcode.itf.min.js
/lib/jquery-validation/dist/jquery.validate.min.js
/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
/lib/jquery-validation/localization/messages_de.js
/bundles/all.min.js

<script defer type="text/javascript">
$(document).ready(function() {
bsCustomFileInput.init();
});
</script>
$(document).ready(function() {
Registration.setupIndexRegistration();
});

Flags: needinfo?(marcodifeo)
Severity: -- → S3
Priority: -- → P3

Do you have any further information or is there anything I can provide to dig deeper where the problem comes from?

Can you check if this happens with the Firefox that is being released today (128)

Yes, I was on the way to try it, before you wrote.
The tab crashes even with 128.0 ESR. Same here, when I remove domain from LocalFileLinks everything works just fine

I just realized I didn't properly look at that mozregression log.

It has

Narrowed nightly regression window from [2022-08-01, 2022-08-05] (4 days) to [2022-08-03, 2022-08-05] (2 days) (~1 steps left)

Which is the best we'll be able to do. I'm going to start looking at those patches manually.

If you don't mind, If you could rerun mozregression, you can set the dates as August 1, 2022 and August 6, 2022 and it should go fast.

There will be a URL in the upper right box for hg.mozilla.org that has a from= and to= in the URL.

that will allow me to look a little quicker.

Here you go: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cfd741e376c8b1044961dc605fb594edc28e798c&tochange=306869bdfd8ec55b1698459b6ab3dddf212b1906

Is it possible to get closer to the commit with mozregression anyhow?
I don't mind if it takes longer, when it helps to enclose the bug.

That pushlog url was from the last (good) entry.
The same url from the bad version with the date 2022-08-04 is https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cfd741e376c8b1044961dc605fb594edc28e798c&tochange=306869bdfd8ec55b1698459b6ab3dddf212b1906

This has been helpful. I've posted come comments in bug 1834864 that hopefully will point to a cause.

Thank you, so we'll see if someone finds this bug. I try to find a way to reproduce this bug on a public Server somehow.

Can you check a current nightly build and see if you can still recreate?

Hey Mike,

I check the current nightly build and it is resolved. Thank you and your team so much for your great work.
Is this change commited to the ESR Version as well, like 128.1 oder 128.2?

Kind Regards
Marco

I'm going to get it uplifted. Probably 128.2

Status: UNCONFIRMED → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1834864
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: