1880245 - Unreported heap-unclassified memory for cert_storage::SecurityState::load_crlite_filter

Status: NEW

(Core :: Security: PSM, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:124.0) Gecko/20100101 Firefox/124.0 ID:20240128212206

Running a Nightly build with DMD enabled shows the following unreported memory:

Unreported {
  36 blocks in heap block record 5 of 47,309
  13,088,768 bytes (13,010,860 requested / 77,908 slop)
  Individual block sizes: 9,650,176; 983,040; 704,512; 491,520; 360,448; 245,760; 180,224; 131,072; 98,304; 65,536; 49,152; 32,768 x 2; 16,384 x 2; 8,192 x 2; 4,096; 3,072; 2,048; 1,536; 1,024; 768; 512; 352; 256; 176; 128; 96; 64; 48; 32 x 5
  1.08% of the heap (10.95% cumulative)
  1.97% of unreported (20.02% cumulative)
  Allocated at {
    #01: replace_calloc(unsigned long, unsigned long) (/Applications/FirefoxNightly.app/Contents/MacOS/libmozglue.dylib + 0x5dd40)
    #02: rust_cascade::Cascade::from_bytes::h0f05d3b5c48a9728 (/Applications/FirefoxNightly.app/Contents/MacOS/XUL + 0x1ed33a0)
    #03: cert_storage::SecurityState::load_crlite_filter::h44c3e60fc1bcc78c (/Applications/FirefoxNightly.app/Contents/MacOS/XUL + 0x567f0a8)
    #04: _$LT$cert_storage..SecurityStateTask$LT$T$C$F$GT$$u20$as$u20$moz_task..Task$GT$::run::hd80d03b4cccdf463 (/Applications/FirefoxNightly.app/Contents/MacOS/XUL + 0x5683f74)
    #05: async_task::raw::RawTask$LT$F$C$T$C$S$GT$::run::h9e31f4af267b9457 (/Applications/FirefoxNightly.app/Contents/MacOS/XUL + 0x1ef1df8)
    #06: moz_task::dispatcher::RunnableFunction$LT$F$GT$::allocate::Run::h25a16d038788515b (/Applications/FirefoxNightly.app/Contents/MacOS/XUL + 0x1ef3450)
    #07: mozilla::TaskQueue::Runner::Run() (/Applications/FirefoxNightly.app/Contents/MacOS/XUL + 0x3e1f44)
    #08: nsThreadPool::Run() (/Applications/FirefoxNightly.app/Contents/MacOS/XUL + 0x3f8e94)
  }
}

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:keeler, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Dana Keeler (she/her) [:keeler]]

If I'm understanding correctly, this memory is reported as part of the MallocSizeOf impl for SecurityState, but I suppose since we use approximate_size_of, DMD doesn't know that? We could add a MallocSizeOf impl for Cascade.