1880315 - [wpt-sync] Sync PR 44588 - Remove corb_detachable.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44588 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44588
Details from upstream follow.

Daniel Vogelheim <[e-mail]> wrote:

Remove corb_detachable.

This is part of cleanup work to remove CORB code, now that its successor ORB has been enabled. This particular CL removes rarely used functionality that we won't need going forward.

This CL should be largely functionally neutral, but it affects two tests:

• One subtest in PrefetchBrowserTest: It seems the test inadvertently
  relied on caching behaviour of ORB-blocked requests. By changing
  the content type to the empty string the resource is not affected
  by ORB at all, and the test should work as originally intended.

• WPT preload/prefetch-document: The test assertions for cross-origin
  resources are not ORB compatible, because ORB would block those
  resources. The change here makes us pass the test 100%; makes
  Firefox (which has also implemented ORB) pass an additional subtest,
  and doesn't affect WebKit (which apparently doesn't implement
  prefetch).

  Ref: https://wpt.fyi/results/preload/prefetch-document.html?label=master&label=experimental&aligned&q=preload%2Fprefetch-document.html

Bug: 324418206
Change-Id: I2fbaec1a51a0cfd5d6df731a831b8a3c09bf0693

Reviewed-on: https://chromium-review.googlesource.com/5277068
WPT-Export-Revision: f67e79025318763a51334de46f19e847f5b8c0d6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=dae208a412954167d152ae735e19a0a3e27fb52c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS : 3
FAIL : 2

Safari

TIMEOUT: 2
NOTRUN : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /preload/prefetch-document.html [wpt.fyi]
  • same origin document prefetch without 'as' should be consumed: FAIL (Safari: TIMEOUT)
  • Document prefetch should send the exact Accept header as navigation: FAIL (Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/183645e2c926
[wpt PR 44588] - Remove corb_detachable., a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/183645e2c926