1880376 - Investigate Test Runner visibilityState For WPT Tests

Status: NEW

(GeckoView :: General, task, P3)

Description

[Olivia Hall [:olivia]]

This bug is to investigate the TestRunner and visibilityState="hidden".

An issue is occurring on the WPT tests in bug 1877469, where tests are failing due to differences in GVE/Fenix vs. the test runner.

• See bug 1877469 comment 10 for tests.
• See bug 1877469 comment 11 and bug 1877469 comment 12 for how to test locally.

A related bug is bug 1678103. There is some uncertainty on that bug in that this bug appears to have been fixed once, but maybe not on all layers.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Olivia, I would like to land my changes on bug 1877469 and wonder which kind of priority this bug actually has. If it will take longer I might have to find a workaround for Android, or mark all the relevant tests as failures. Thanks.

Comment 2

[Olivia Hall [:olivia]]

Thanks for the ni reminder! I'll bring it up in our team channel again to get a priority.

Comment 3

[Olivia Hall [:olivia]]

Hi Henrik,

I think it might be a bit before we can look at this bug. I expect it will require a deeper dive too to see what is going on with the visibilityState overall in the stack. Marking them as failures so you can land is probably the best approach right now until we have some time.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alright I will try a workaround until then. Do you know if there is a way to determine the kind of package from within Gecko? Probably not.

Reason I'm asking is that I would have to exclude some code from running when Gecko is embedded in the TestRunner, but run it for other packages. If that's not possible I probably have to turn off the check for visibilityState completely for Android. Thanks.

Comment 5

[Olivia Hall [:olivia]]

Do you know if there is a way to determine the kind of package from within Gecko?

I don't think so, but it would make sense to have. (IIUC, we used to have some defines for checking for Fennec, for example. This documentation kinda lends to that thought.)

If you have anything to add to bug 1883945, please mention!

If that's not possible I probably have to turn off the check for visibilityState completely for Android.

Probably the only option now, unless there is a newly introduced monorepo flag that I don't know about yet.

Comment 6

[[:owlish] 🦉 PST]

Seeing that Henrik found a workaround, setting the priority to P5 (realistically, with our workload), but if needed, we can re-triage

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to [:owlish] 🦉 PST from comment #6)

Seeing that Henrik found a workaround, setting the priority to P5 (realistically, with our workload), but if needed, we can re-triage

Please note that we do not have a workaround. We just disabled the tests for Android as long as we have to use the TestRunner. So this probably affects the priority of this bug?