1880541 - Tweak test_system_update_enterprisepolicy.js to be less confusing when if fails because of non-test enterprise policies have been loaded instead

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Not a bug per se, but the test case test_system_update_enterprisepolicy.js will fail if executed on a developer machine where an enterprise policy json file is found at system level, which end up silently be used instead of the enterprise policies data set by the test case itself, and then hitting an assertion failure about unexpected system addons directories found, which in practice under this corner case doesn't help to understand that the failure is hit not because of a bug or regression but because of enterprise policy already existing in the same system.

I got to hit this corner case because I was testing out something around enterprise policies and forgot to remove that test enterprise policy from my system, and after a few days I was getting failures on this test and didn't make the connection between the failure and the enterprise policy I was testing out a few days earlier until I actually investigated the failure deeply enough to determine what was going on.

Asserting explicitly that the enterprise policy returned by Services.policies.getActivePolicies should be matching the test policy set by the test itself would have been useful, maybe also mentioning in the assertion message to double-check enterprise policies installed at system level in case of failures may also be a reasonable way to help a developer hitting the failure to more quickly pinpoint what is triggering it.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1880541 - Add to test_system_update_enterprisepolicy.js an explicit assertion on the active policies data. r?willdurand!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/376210fa8624
Add to test_system_update_enterprisepolicy.js an explicit assertion on the active policies data. r=willdurand

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/376210fa8624