Closed Bug 1880577 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 44621 - Make dir=auto elements without strong characters ltr (rather than inheriting).

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 44621 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44621
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Make dir=auto elements without strong characters ltr (rather than inheriting).

This reverts (conditioned on a new DirAutoNoInheritance flag) a previous
change from https://crrev.com/c4557b863d101826932f33757e9398e7fca056c9
and makes it so that dir=auto elements never inherit directionality from
their parent. Instead, when no strong characters are present, they have
LTR directionality, as we did before.

Reverting to our old behavior (and reverting the relevant test to its
old state) seems like the best option given the discussion in
https://github.com/whatwg/html/issues/10097 .

Once this ships to stable we can remove the mechanisms used to support
that inheritance.

The changes in html/dom/elements/global-attributes/dir_auto-N-EN.html
and its reference are a direct revert of the prior test change.

The new dir-shadow-42 test is a version of dir-shadow-41 with the
directions swapped, to make sure things are tested more thoroughly.

Fixed: 41494751
Bug: 576815
Change-Id: I68b36a1fc19a0553f582fdf2fd02a94d6e633686

Reviewed-on: https://chromium-review.googlesource.com/5302287
WPT-Export-Revision: cc7175d71cdaf0163b442fb08b6b1fa171788872

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 34 subtests

Status Summary

Firefox

OK : 1
PASS: 34
FAIL: 4

Chrome

OK : 1
PASS: 32
FAIL: 6

Safari

OK : 1
PASS: 35
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /html/dom/elements/global-attributes/dir-assorted.window.html [wpt.fyi]
    • Non-HTML element outside the document tree has a direction: FAIL (Chrome: PASS, Safari: FAIL)
    • Non-HTML element without direction has parent element direction: FAIL (Chrome: PASS, Safari: FAIL)
    • Non-HTML element text contents influence dir=auto: FAIL (Chrome: PASS, Safari: FAIL)
    • text changes apply to dir=auto on further ancestor after removing dir=auto from closer ancestor: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/418cb3b6aaa4 [wpt PR 44621] - Make dir=auto elements without strong characters ltr (rather than inheriting)., a=testonly https://hg.mozilla.org/integration/autoland/rev/ed64e0dc5e05 [wpt PR 44621] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/418cb3b6aaa4
https://hg.mozilla.org/mozilla-central/rev/ed64e0dc5e05

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.