1880629 - 0.29 - 0.13% installer size / installer size (OSX) regression on Thu February 8 2024

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Acasandrei Beatrice (needinfo me)]

Perfherder has detected a build_metrics performance regression from push a39978d779e2f23b325bb042f23c42517d1b7b37. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.29%	installer size	osx-nightlyasrelease	nightly nightly-as-release	90,642,410.96 -> 90,904,141.08
0.13%	installer size	osx-nightlyasrelease	nightly nightly-as-release	90,746,221.46 -> 90,860,948.75

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

You can run these tests on try with ./mach try perf --alert 41498

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1868727

Comment 2

[Kershaw Chang [:kershaw]]

The change in bug 1868727 is about http3server, which is only used for internal testing.
I am not sure why http3server is packed into the installer, but I think this regression might be fine.

Mike, do you probably have an idea here?
Thanks.

Comment 3

[Mike Hommey [:glandium]]

Http3server is not in the installer. The noise in the measure is not helping, and you seem to be victim of misattribution due to the noise. XUL section sizes would be slightly more reliable to track this down, but as you can see from its graph it's not necessarily much better. In principle, the regressions on the non-PGO XUL section sizes would help. https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&replicates=0&series=autoland,2614663,1,2&timerange=1209600

Comment 4

[Mike Hommey [:glandium]]

FWIW, I filed bug 1881122 for one of the causes of noise that shouldn't exist (but that's merely one).

Comment 5

[Acasandrei Beatrice (needinfo me)]

(In reply to Mike Hommey [:glandium] from comment #3)

Http3server is not in the installer. The noise in the measure is not helping, and you seem to be victim of misattribution due to the noise. XUL section sizes would be slightly more reliable to track this down, but as you can see from its graph it's not necessarily much better. In principle, the regressions on the non-PGO XUL section sizes would help. https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&replicates=0&series=autoland,2614663,1,2&timerange=1209600

Thanks for all the details provided, I'll close this.