1880747 - bottom of page covered by URL bar if different domain is opened in PWA

Status: REOPENED

(Firefox for Android :: PWA, defect)

Description

[FxN98]

Attachment: Screenshot_2024-02-18-13-33-05-12_3aea4af51f236e4932235fdada7d1643.jpg

User Agent: Mozilla/5.0 (Android 12; Mobile; rv:122.0) Gecko/122.0 Firefox/122.0

Steps to reproduce:

1. Add a page/PWA to the home screen (three dots, then "Add to Home screen")
2. Open this new standalone app from my home screen
3. Click a link within this standalone app that's from a different (sub-)domain

Actual results:

The page opens with a bar at the bottom showing the URL, Share-Button and Menu-Button.
This bar covers the bottom part of the website and does not disappear.
You are unable to see the bottom of the page, where some pages have important content like links or sticky buttons to interact with.

Expected results:

The bar at the bottom should either disappear, similar to how it works when opened directly in the browser OR is should not cover the bottom but instead have the bottom of the page right above it.

Comment 1

[jackyzy823]

More clear STR:

1. Open "https://community.wanikani.com" in normal tab, then 3-dot menu -> Install.
2. Open the installed PWA shortcut.
3. Click "Try wanikani for free" link at the top of page and wait the page loaded
4. Scroll to the end of page and compare with the page's end of "https://www.wanikani.com" which opened in the normal tab. The page in PWA only shows the logo but not shows the copyright info.

Related code:
https://searchfox.org/mozilla-mobile/rev/25f85391c774117bce2d56fc3e4be25286567193/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt#95

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1880747 - Set toolbar height when visible on PWA (#5644)

Comment 3

[Vasilica Tamas (Android QA) [:vtamas]]

I was able to reproduce this issue on Firefox Nightly 124 (2024-02-19) and Firefox 123.0 using a Samsung Galaxy A32 with Android 13. The footer is not entirely visible on same pages in PWA. Confirming as NEW.

Comment 4

[FxN98]

I think the severity of this should be S3 as it blocks some functionality on certain sites. In the WaniKani forum (https://community.wanikani.com/) or this forum here, for example it blocks the functionality to reply to a thread as these are placed at the very bottom. On the WaniKani forum it also blocks the fast scrolling feature which is basically necessary for reading long threads.
The workaround is to open the site directly in Firefox instead of through the originally used PWA which works fine except that firefox for me doesn't directly show the page.

Comment 5

[Fxzx Axon]

Attachment: Screenrecording_20240307_161444.mp4

Encountered the same problem, hope to fix it as soon as possible.

Comment 6

[jackyzy823]

Attachment: Bug 1880747 - Set toolbar height when visible on PWA. r=#android-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/439d41b187a0
Set toolbar height when visible on PWA. r=android-reviewers,twhite

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/439d41b187a0

Comment 10

[tszentpeteri]

Backed out requested by twhite for causing bug 1896007.

• Backout link

Comment 11

[Pascal Chevrel:pascalc]

Backed out changeset 439d41b187a0 (bug 1880747) as requested by twhite for causing bug 1896007. a=pascalc
https://hg.mozilla.org/releases/mozilla-beta/rev/9140e25b645b

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:jackyzy823, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 13

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.