1880833 - Consider re-enabling fade-in animation on cocoa popups.

Status: RESOLVED INCOMPLETE

(Core :: Widget: Cocoa, defect, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1880833 - Re-enable fade-in animation on macOS big-sur+. r=mstange!

This doesn't seem to cause perf issues on the parent process side of
things, and the appearance nowadays looks correct with the extra
invalidateShadow call. At least, shadowParameters and co only seem to
get called twice.

Comment 2

[Markus Stange [:mstange]]

So you're saying this part of the bug I filed has been addressed?

We can add calls to invalidateShadow, but this does not achieve the desired shadow look.
The undesirable look manifests as follows:
In the past, no shadow was visible behind opaque areas of the window, regardless of window alpha. But in Big Sur, opaque areas of a window do have a shadow visible behind them if the window’s alpha value is partially-transparent, e.g. 0.5. The opaque areas no longer “knock out” the shadow. This undesired shadow creates a darkening effect and looks especially unsightly during fade animations.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

That seems to be the case from my testing with that patch's reduced test-case (nice work there btw!)

Comment 4

[Markus Stange [:mstange]]

I can't confirm this. Clicking the window in the example app from attachment 9183839 [details] still changes the shadow appearance on macOS 14.1.1.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

You mean clicking the "invalidate shadow" button? Because that is expected (and my patch adds an invalidateShadow call to remedy that). Or you mean something else?

Comment 6

[Markus Stange [:mstange]]

I disagree that it is expected. Clicking the "invalidate shadow" button should not change rendering: The contents of the window haven't changed, so the shadow shouldn't need to change. Only the opacity has changed, and it should be applied to both the window and the shadow at the same time, only once.
So that probably also means that I didn't phrase the bug I filed well enough.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from a reviewer who resigned from the review:

ID	Title	Author	Reviewer Status
D202148	Bug 1880833 - Re-enable fade-in animation on macOS big-sur+. r=mstange!	emilio	mstange: Resigned from review

:emilio, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

I still think we should try this