Closed Bug 188130 Opened 20 years ago Closed 17 years ago

XML Pretty-Print doesn't work in Camino

Categories

(Camino Graveyard :: Page Layout, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Camino1.0

People

(Reporter: pbaker, Assigned: sfraser_bugs)

References

()

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20030107 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20030107 Chimera/0.6+

XML Pretty-Printing (similar to IE) was implemented in Mozilla in bug#64945. Can
this feature be added to Chimera please. This is one of those must have features
in Mozilla that keeps me from using Chimera as my primary browser.

Reproducible: Always

Steps to Reproduce:
1. visit http://bugzilla.mozilla.org/attachment.cgi?id=31654&action=view

Actual Results:  
only the text "raboof hiihaa" is displayed in the window.

Expected Results:  
You should see pretty printed xml that looks similar to this:

- <doc foo="bar">
    <a/>
    raboof
    <x:b>hiihaa</x:b>
  </doc>

The - in the first line is clickable and allows you to expand or collapse the tag.
Agreed. This is one of the few missing features that keeps me switching back to
Mozilla (the other being incorrect view source behavior). Last week I would have
said leave it out, but now that Safari is out, I think this would be a good
feature to help differentiate Chimera as a superior browser.
won't this be fixed in Chimera when it moves to the trunk later this year?
*** Bug 187521 has been marked as a duplicate of this bug. ***
Status: UNCONFIRMED → NEW
Depends on: xmlview
Ever confirmed: true
Summary: XML pretty-printing should be enabled in Chimera → Migrate Mozilla's XML pretty-printing patch to Chimera
Chimera is now Camino and is on trunk for some time now. 
Bug is present with build id 2003082402.
Bug still here with Camino nightly build 20040208, Mac OS 10.3.2.

This should be fixed by now, I would have thought...
I wonder why this doesn't work. I don't think it was implemented as an optional
extension; doesn't Camino just include this code already?

(Doesn't work even with 'user_pref("layout.xml.prettyprint", true);' in user.js.)
Severity: enhancement → normal
Summary: Migrate Mozilla's XML pretty-printing patch to Chimera → XML Pretty-Print doesn't work in Camino
Hm, the pretty-print patch appears to use XSLT, so I thought this might get
fixed by the check-in of bug 202022's fix, but apparently not. Maybe that was
part of the problem, though.
Seems tha all needed files to run xml pretty prin are located here:
mozilla/content/xml/document/resources

Some css files and jar file that needs to be included. Anybody?
Bump, putting on the 1.0 list as this is a standard MF browser feature.
Target Milestone: --- → Camino1.0
I edited embed-jar.mn to include the resources in xml/document/resources, but
that doesn't appear to be enough. Trying to load an XML file then gives:

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(result)) failed, file
../../../../../../mozilla/content/xml/document/src/nsXMLContentSink.cpp, line 985
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(result)) failed, file
../../../../../../mozilla/content/xml/document/src/nsXMLContentSink.cpp, line 985
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
../../../../../../mozilla/extensions/transformiix/source/xslt/txStylesheetCompileHandlers.cpp,
line 500
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
../../../../../../mozilla/extensions/transformiix/source/xslt/txStylesheetCompiler.cpp,
line 326
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
../../../../../../mozilla/extensions/transformiix/source/xslt/txMozillaStylesheetCompiler.cpp,
line 642
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
../../../../../../mozilla/extensions/transformiix/source/xslt/txMozillaStylesheetCompiler.cpp,
line 682
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
../../../../../../mozilla/extensions/transformiix/source/xslt/txMozillaXSLTProcessor.cpp,
line 353
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
../../../../../../mozilla/content/xml/document/src/nsXMLPrettyPrinter.cpp, line 147
Attachment #185111 - Flags: superreview?(bryner)
Attachment #185111 - Flags: review?(benjamin)
Taking.
Assignee: bryner → sfraser_bugs
Comment on attachment 185111 [details] [diff] [review]
Patch: adds some resources to embed-jar.mn

r=me for build-config changes, no sr needed
Attachment #185111 - Flags: superreview?(bryner)
Attachment #185111 - Flags: review?(benjamin)
Attachment #185111 - Flags: review+
Attachment #185111 - Flags: approval1.8b3?
Attachment #185111 - Flags: approval1.8b3? → approval1.8b3+
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
VF using 1.0b2.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.