1881328 - [wpt-sync] Sync PR 44712 - DOM: Implement the `drop()` Observable operator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44712 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44712
Details from upstream follow.

Dominic Farolino <[e-mail]> wrote:

DOM: Implement the drop() Observable operator

This CL implements the semantics specified in
https://wicg.github.io/observable/#dom-observable-drop.

See https://github.com/WICG/observable/pull/117.

For WPTs:
Co-authored-by: [e-mail]

R=[e-mail]

Bug: 40282760
Change-Id: I8c012c71675a2625c5120624c4f2a19a4d06462c
Reviewed-on: https://chromium-review.googlesource.com/5294714
WPT-Export-Revision: f8b242b46c143f7c756cbaf74fc65d7fb692290e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b334d67c6fcda521c812dd5456c08eec36068f2d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
FAIL: 14

Chrome

OK : 2
FAIL: 14

Safari

OK : 2
FAIL: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/observable/tentative/observable-drop.any.worker.html [wpt.fyi]
  • drop(): Observable should skip the first n values from the source observable, then pass through the rest of the values and completion: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Observable passes through errors from source Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Observable passes through errors from source observable even before drop count is met: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Observable passes through completions from source observable even before drop count is met: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Unsubscribing from the Observable returned by drop() also unsubscribes from the source Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): A drop amount of 0 simply mirrors the source Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Passing negative value wraps to maximum value : FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/observable/tentative/observable-drop.any.html [wpt.fyi]
  • drop(): Observable should skip the first n values from the source observable, then pass through the rest of the values and completion: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Observable passes through errors from source Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Observable passes through errors from source observable even before drop count is met: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Observable passes through completions from source observable even before drop count is met: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Unsubscribing from the Observable returned by drop() also unsubscribes from the source Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): A drop amount of 0 simply mirrors the source Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • drop(): Passing negative value wraps to maximum value : FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29ee4a773096
[wpt PR 44712] - DOM: Implement the `drop()` Observable operator, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2c3d8a9eb427
[wpt PR 44712] - Update wpt metadata, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/29ee4a773096
https://hg.mozilla.org/mozilla-central/rev/2c3d8a9eb427