1881329 - Revert "Add close method to file picker"

Status: RESOLVED FIXED

(Core :: Widget, task)

Description

[Ray Kraesig [:rkraesig]]

Sadly, it doesn't appear to be possible to implement a file-picker-close method for Win32 — at least not without a rework of fundamental parts of the file-picker and/or utility-process implementations. (Which are wanted for other reasons, but won't be done soon.)

For now, at least, we should revert the addition of Close() to the cross-platform interface, lest someone try to build on top of it and find they've designed something that will only work on Linux.

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1881329 - Revert addition of nsIFilePicker::Close() r?emilio,canadahonk

This function can't be implemented for Win32 (yet?), partly due to
internal architectural issues. (See bug 1870660 for more details.)

Remove the existing stubs (and perfectly-functional Gtk implementation)
as dead code until such time as they can be made live.

(This commit also reverts a fix to this code from bug 1872834, which
should be restored if and when the rest of it is.)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11e8c520bc95
Revert addition of nsIFilePicker::Close()  r=emilio

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/11e8c520bc95