1881457 - onchange not fired when clear value of textarea

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[jochen.kremer]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

<textarea onchange="alert('change')">12345</textarea>

Select full text and delete id, then leave field.

Actual results:

Nothing happens. Onchange is not fireing,
It´s only fireing when i delete a part of the value and then the rest.

Expected results:

The event should fireing also whe i delete the full value at the first time. We checkt this. In Version 1.2.2 it´s working. In 1.2.3 it´s broken

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: Onchange event does not fire

STR:

1. Open data:text/html,<textarea onchange="alert('change')">12345</textarea>
2. Focus the textarea and select full text
3. Delete the selected text (Hit DEL key or Ctrl+X)
4. Take the focus away from the textarea (click on page body)

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fd640ad054ea9962a833d4d1e406f3bd63577a68&tochange=50e9acd8344672f53caae7463162c31c627b3546

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1850295, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Pascal Chevrel:pascalc]

Emilio, could you set the severity for this regression? Thanks

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1881457 - Keep saving mFocusedValue. r=smaug,#dom-core

This deletion was an oversight of the regressing bug. Kind of
embarrassing we didn't have a test for it...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9c166671119
Keep saving mFocusedValue. r=smaug

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44734 for changes under testing/web-platform/tests

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e9c166671119

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9382049 [details]
Bug 1881457 - Keep saving mFocusedValue. r=smaug,#dom-core

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Restores previous behavior, one-liner.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9382049 [details]
Bug 1881457 - Keep saving mFocusedValue. r=smaug,#dom-core

Approved for 124.0b4

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1538b6e1484e

Comment 14

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue on an affected build, on Windows 10.
Verified as fixed on Firefox 124.0b4 (20240226091939) and 125.0a1 (20240226165659) on the following platforms: Win 10, Win 11, Ubuntu 22 and macOS 11.

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9382049 [details]
Bug 1881457 - Keep saving mFocusedValue. r=smaug,#dom-core

123 regression, low risk, let's take it in our planned dot release next week, thanks.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/77afdd48e17f

Comment 17

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/77afdd48e17f

Comment 19

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox 123.0.1 (20240304104836) on the following platforms: Windows 10, Windows 11, Ubuntu 22 and macOS 11.