1881624 - Misalignment between urlbar identity icon and its searchglass version

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect, P3)

Description

[Shane Hughes [:aminomancer]]

Attachment: screen recording

When the urlbar's identity icon is in search mode, its inline margins are much greater than in other modes where it can be clicked as a button.

See attached screen recording.

Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ae389473ba61480f5ae70369585727aef6010fc7&tochange=49c2d107e082c2e891f92fa8a40582f14eb89c38

I suppose it's hard to avoid misalignment with something. Either the identity icon is misaligned with the result favicons, or it's misaligned with itself (when navigating or switching between tabs). But I think this might be worse than the result misalignment, which feels pretty nitpicky. Like, the result misalignment isn't good, and I'd certainly prefer if they aligned, but it doesn't feel like a bug. It just feels like the icons weren't intended to align. But when I navigate and I see the urlbar text move to the right/left, and the space around the identity icon grow, it feels like a bug. Technically speaking, the jank factor feels higher :P

It might be resolved by reducing the margins of the result favicons to bring them into line with the identity icon, rather than adjusting the identity icon to match the favicons.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839921

:daleharvey, since you are the author of the regressor, bug 1839921, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1881624 - Correctly align urlbar icons. r=Dao

Comment 3

[Dale Harvey (:daleharvey)]

Ok yeh spent some time trying to fix this and as Dao mentioned in https://phabricator.services.mozilla.com/D204238, there are a lot of cases where we arent going to be able to align as the order of the icons can be different, the width of some of them is different etc. Fixing it for this case seems to open a bit of a can of worms.

Going to close this wontfix, however we have some upcoming features that are likely going to change the layout here and so we can account for this in the design (as opposed to the current situation where rich suggestions were added after the rest had been designed and implemented)