Remove unused method PermissionManager::LegacyTestPermissionFromURI
Categories
(Core :: Permission Manager, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: emz, Assigned: tvaleev.browser, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, priv-triaged, Whiteboard: [lang=c++])
Attachments
(1 file)
In Bug 1574469 I updated callers to check permissions by principal. PermissionManager::LegacyTestPermissionFromURI is leftover and can be removed.
|
Reporter | |
Updated•1 year ago
|
|
|
Reporter | |
Updated•1 year ago
|
I think I can take this bug, if it is still available. All I have to do is delete the whole method named PermissionManager::LegacyTestPermissionFromURI() then? Also this is my first contribution so I would need a mentor. Thanks in advance.
|
|
Reporter | |
Comment 2•1 year ago
|
||
Sure! Sorry for the late reply I was out of office. I can mentor you on this bug. Do you already have a local copy of mozilla-central? If not here is how to clone the code and build Firefox: https://firefox-source-docs.mozilla.org/setup/index.html
(In reply to Paul Zühlcke [:pbz] from comment #2)
Sure! Sorry for the late reply I was out of office. I can mentor you on this bug. Do you already have a local copy of mozilla-central? If not here is how to clone the code and build Firefox: https://firefox-source-docs.mozilla.org/setup/index.html
All good! I'll get started on this tomorrow. I've been a little busy myself lately. Thank you
|
||
Comment 4•10 months ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
|
Assignee | |
Comment 5•9 months ago
|
||
|
||
Updated•9 months ago
|
The review request is already there, no need for needinfo 👍
|
|
||
Updated•9 months ago
|
|
||
Comment 9•9 months ago
|
||
| bugherder | ||
Description
•