1881838 - [wpt-sync] Sync PR 44756 - [FedCM] Allow button flow to replace widget flow

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44756 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44756
Details from upstream follow.

Yi Gu <[e-mail]> wrote:

[FedCM] Allow button flow to replace widget flow

Since button flow implies stronger user login intention of, it should
take precedence over the widget flow. In particular:

1. If there's an in-flight button request, reject any coming widget request
2. If there's an in-flight widget request, replace it with the button request

This patch also fixes an issue where we persisted the rp_mode_ after a
button flow.

Bug: 41483050
Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9
Reviewed-on: https://chromium-review.googlesource.com/5321982
WPT-Export-Revision: 4e0df10cbf51c6e5e864a592e84fbfeda9f0824c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44756 applied with additional changes from upstream: 81a33691a856a09d54ed986a17be287d91b49fae

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=071db03b52088cf08d4dfa0997b64e3909f95a86

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 3

Chrome

TIMEOUT: 2
NOTRUN : 3

Safari

PASS : 1
FAIL : 3
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-button-mode-basics.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)
  • Test that the button mode without user activation will fail.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
  • Test that the button mode requires user activation.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the button mode can replace widget mode.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the widget mode can succeed after the button mode.: NOTRUN (Chrome: NOTRUN, Safari: PASS)

Tests Disabled in Gecko Infrastructure

• /credential-management/fedcm-button-mode-basics.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11d9c43ed0ab
[wpt PR 44756] - [FedCM] Allow button flow to replace widget flow, a=testonly

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/11d9c43ed0ab