1882030 - 2.44 - 2.22% tp5o / tp5o (Linux) regression on Wed February 21 2024

Status: RESOLVED DUPLICATE of bug 1881883

(Core :: Networking: Proxy, defect, P2)

Description

[Florin Bilt]

Perfherder has detected a talos performance regression from push acaa8b529bb7da3e76b4874321aa5bb7f16f5a06. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	tp5o	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	194.28 -> 199.03
2%	tp5o	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	194.73 -> 199.04

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 41577

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1879848

Comment 2

[Manuel Bucher [:manuel]]

I'd like to see whether landing Bug 1881883 fixes the performance regression. Otherwise I'd be in favor of backing out and introducing the telemetry elsewhere.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Manuel, please close this after bug 1881883 lands if it fixes the issue (I think it will).

Comment 4

[Manuel Bucher [:manuel]]

Results will be here: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=1eb05f76076314cb537cab06a5743e5107a0aab8&newProject=try&newRevision=d33a615cbba9fb45a8be4c83992d783bc3f715eb

HEAD ist jetzt bei 35baefc7c23b7 Bug 1882186 - Fix black lint failure in bootstrap.py r=fix CLOSED TREE
estimates: Runs 3 tasks (1 selected, 2 dependencies)
estimates: Total task duration 0:19:50
estimates: Should take about 1:04:03 (Finished around 2024-02-27 19:39)
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: recorded push in pushlog
remote: added 1 changesets with 1 changes to 1 files (+1 heads)
remote: 
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/1eb05f76076314cb537cab06a5743e5107a0aab8
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/jobs?repo=try&revision=1eb05f76076314cb537cab06a5743e5107a0aab8
remote: recorded changegroup in replication log in 0.011s
To hg::ssh://hg.mozilla.org/try
 * [new branch]                  HEAD -> branches/default/tip
Zu Branch 'branches/default/tip' gewechselt
estimates: Runs 3 tasks (1 selected, 2 dependencies)
estimates: Total task duration 0:19:50
estimates: Should take about 1:04:03 (Finished around 2024-02-27 19:41)
remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '5410' on host 'hgssh1.dmz.mdc1.mozilla.com/effffffc'
remote: got lock after 24 seconds
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: recorded push in pushlog
remote: added 1 changesets with 1 changes to 1 files (+1 heads)
remote: 
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/d33a615cbba9fb45a8be4c83992d783bc3f715eb
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/jobs?repo=try&revision=d33a615cbba9fb45a8be4c83992d783bc3f715eb
remote: recorded changegroup in replication log in 0.010s
To hg::ssh://hg.mozilla.org/try
 * [new branch]                  HEAD -> branches/default/tip

!!!NOTE!!!
 You'll be able to find a performance comparison here once the tests are complete (ensure you select the right framework): https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=1eb05f76076314cb537cab06a5743e5107a0aab8&newProject=try&newRevision=d33a615cbba9fb45a8be4c83992d783bc3f715eb

Comment 5

[Manuel Bucher [:manuel]]

I don't see the regression being reversed with the patch that landed with Bug 1881883. I'm not sure if I followed the correct steps. With the patch https://hg.mozilla.org/mozilla-central/rev/8045550b3836 I would expect the regression to be reversed. @Florian, since one option was to ask a sheriff to run the profiling jobs, can you redirect this to a sheriff to verify whether the patch has fixed the regression?

Comment 6

[Florin Bilt]

(In reply to Manuel Bucher [:manuel] from comment #5)

I don't see the regression being reversed with the patch that landed with Bug 1881883. I'm not sure if I followed the correct steps. With the patch https://hg.mozilla.org/mozilla-central/rev/8045550b3836 I would expect the regression to be reversed. @Florian, since one option was to ask a sheriff to run the profiling jobs, can you redirect this to a sheriff to verify whether the patch has fixed the regression?

Hi Manuel, yes we can confirm that the regression was fixed by the revision you specified .

== Change summary for alert #41609 (as of Thu, 29 Feb 2024 11:23:39 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	tp5o_webext	windows10-64-shippable-qr	e10s fission stylo webrender	297.06 -> 287.75
2%	tp5o	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	199.26 -> 194.96
2%	tp5o	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	199.13 -> 195.64

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41609

Comment 7

[Manuel Bucher [:manuel]]

Thanks for bringing it up to our attention and verifying the fix. The fix landed in Bug 1881883, so closing as duplicate. The two bugs describe different symptoms of the same problem. Feel free to change the resolution if you feel like something else fits better.