1882093 - Investigate and Improve Translations Error Handling

Status: NEW

(Firefox for Android :: Translations, enhancement, P3)

Description

[Olivia Hall [:olivia]]

This bug is to investigate translations error handling.

Background:

• There are two types of errors, session (tab) and browser (global).
• Core errors for the session are on translationsError, non-core or specific settings errors are on the corresponding error.
• Global errors are on the browser on engineError

This bug is to investigate and take action on error handling, either on this bug or filing follow-ups.

Some recommendations:

• Refactor translationsError name
• Check if settingsError is required
• Look into using a map of TranslaitonsOperation: TranslationError for the session error

See more ideas here.

Comment 1

[Olivia Hall [:olivia]]

Related conversation and ideas to consider here too.

Comment 2

[Mira Lobontiu (Android QA)]

Attachment: error states.jpg

Hi Olivia!
Is this bug referring to the error states from the screenshot?
So far, we were not able to trigger them in Nightly 125.0a1 from 3/13.

Comment 3

[Olivia Hall [:olivia]]

Thanks! This is a bit of an older engineering ticket for any clean up work and improvements we need to do on errors states.

I have STR for the following errors:

For language not supported error:

• Visit https://uz.wikipedia.org/

For “There was a problem translating”:

• Go to a page with reader mode
• Open reader mode
• Try to translate while on reader mode
  (This method will be fixed in bug 1884769.)

For "Couldn't load languages":

• Go to airplane mode with no network
• Fresh install of app (not sure if clearing the profile will work)
• Navigate to about:about, try to translate

And, I just noticed the error didn't show for "Couldn't load languages" in that situation and I expected it to, so I filed this ticket for that issue: bug 1885336.

Comment 4

[Olivia Hall [:olivia]]

Saw an example of overwriting errors in bug 1885336. (Couldn't Load Languages did occur, but later errors overwrote it.) Found a work around, but for future work, we should find a way to aggregate or store errors.

Comment 5

[Mira Lobontiu (Android QA)]

Hi, Olivia,

1. The "There was a problem translating. Please try again" error message cannot now be triggered with the steps from Comment 3.
   Could you provide us other steps in order to be able to trigger this error?

2. For For "Couldn't load languages":

• Go to airplane mode with no network
• Fresh install of app (not sure if clearing the profile will work)
• Navigate to about:about, try to translate --> the displayed error message was "There was a problem translating. Please try again", not the "couldn't load languages."

Thank you!

Comment 6

[Olivia Hall [:olivia]]

Thanks for testing and bringing up these test cases!

1. The "There was a problem translating. Please try again" error message cannot now be triggered with the steps from Comment 3.
   Could you provide us other steps in order to be able to trigger this error?

I'll be on the lookout for more situations for this scenario! The one you found, not being able to translate on the about pages would also be good test case. So, when the language lists are available, and the user tries to translate an about page, then it should fail with "There was a problem translating. Please try again".

1. "There was a problem translating. Please try again" error:

• Navigate to about:about with WiFi with the language lists available
• Press translate

2. For For "Couldn't load languages":

• Go to airplane mode with no network
• Fresh install of app (not sure if clearing the profile will work)
• Navigate to about:about, try to translate --> the displayed error message was "There was a problem translating. Please try again", not the "couldn't load languages."

This second one is a bit tricky because if the languages are ever loaded, even once during the app's lifetime, then the issue won't occur in the future.

Maybe try:

2. "Couldn't load languages" error:

• Delete existing app entirely
• Reinstall app (wait to open app until airplane mode is on and the network is off)
• Go to airplane mode with no network
• Open the app
• Turn feature on via Nimbus
• Navigate to about:about -> Try to translate

Thanks, and I'll try to think of other scenarios!

Comment 7

[Mira Lobontiu (Android QA)]

Thank you, Olivia, the "There was a problem translating. Please try again" error message was displayed with the steps provided by you.