Closed Bug 1882099 Opened 2 years ago Closed 2 years ago

TabHoverStart and TabHoverEnd events are dispatched unnecessarily

Categories

(Firefox :: Tabbed Browser, defect)

defect

Tracking

()

VERIFIED FIXED
125 Branch
Tracking Status
firefox125 --- fixed
firefox126 --- verified

People

(Reporter: mossop, Assigned: mossop)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Because they are triggered from mouseover/mouseout events we end up sending these even when moving within elements inside the tab element.

It's not clear that there is any user-visible bug here but it is causing the
tab preview to get reset multiple times when that is unnecessary which at the
very least makes debugging harder than it needs to be.

Attachment #9384625 - Attachment description: Bug 1882099: Only dispatch TabHoverStart and TabHoverEnd events when actually entering/leaving the tab. r=#tabbrowser-reviewers! → Bug 1882099: Only call _mouseenter and _mouseleave when entering or leaving the tab. r=#tabbrowser-reviewers!
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c77ac99c3ed Only call _mouseenter and _mouseleave when entering or leaving the tab. r=tabbrowser-reviewers,dao
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Blocks: 1876522

This looks fixed to me using latest Nightly 126.0a1 on Windows 11 and Ubuntu 22.04, also I did a quick check on mac to see that no regression were introduced. Looks good. Closing as Verified since this will not launch in Beta 125 but 126.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: