188210 - [FIX]Inspector doesn't outline/blink iframes or elements within them

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

_Probably_ due to problems with the fact that drawing into the iframe means
drawing into a different gdk surface, so the offsets in
inLayoutUtils::GetClientOrigin() aren't correct.

This is GetClientOrigin:
  nsPoint result(0,0);
  nsIView* view;
  aFrame->GetOffsetFromView(aPresContext, result, &view);
  while (view) {
    nscoord x, y;
    view->GetPosition(&x, &y);
    result.x += x;
    result.y += y;
    view->GetParent(view);
  }
  return result;

This gives you an offset from the window's surface, which is badly offset
relative to the iframe's surface.

Note: this theary hasn't been tested yet, but I have some reasons to believe
that may be the cause.  Could be wrong, however.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Adding bz; timeless says bz knows about this (as does caillon).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: this has been bugging me for ages; and you're right.

Comment 3

[Boris Zbarsky [:bzbarsky]]

may as well take this...

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 110983 [details] [diff] [review]
this has been bugging me for ages; and you're right.

Excellent!  Though ISTR another bug filed about this, which should get duped
here.

Comment 5

[Christopher Hoess (gone)]

Bug 112830, maybe?

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

That is what I had in mind, but it's not a dupe after looking again.

Comment 7

[kinmoz]

Comment on attachment 110983 [details] [diff] [review]
this has been bugging me for ages; and you're right.

The old code included the position of the root view in the result ... should we
be checking for a change in view managers instead?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: kin's right; we want the offset of the root view too....

Comment 9

[kinmoz]

Comment on attachment 111046 [details] [diff] [review]
kin's right; we want the offset of the root view too....

sr=[e-mail]

Comment 10

[Boris Zbarsky [:bzbarsky]]

fixed.